Preserve current Content state in Slack corrections#2186
Conversation
|
Here's a visual recap of what changed: Open the full interactive recap |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Builder reviewed your changes — looks good ✅
Review Details
Incremental Code Review Summary
The latest commit fixes the previously reported webhook metadata issue by preserving isError and completedSideEffect in collectToolResultSummaries, and it adds regression coverage proving failed/incomplete writes do not generate artifact links. It also updates the Content guidance to require pull-document before external corrections, resolving the stale collaborative-state concern.
The receipt and fallback paths remain sound: only completed, non-error mutation events feed verified receipts, conflicts are excluded, and nested A2A artifacts retain their target-app origin. Two independent incremental reviews found no new actionable defects. The prior conditional-write/CAS concern remains open and was intentionally not reposted because it is already visible on the PR.
Risk level: Standard.
🧪 Browser testing: Skipped — PR only modifies backend/integration logic, skills, and tests; no browser UI impact.

Summary
Verification
vitestfocused suite: 116 tests passedpnpm --filter @agent-native/core typecheckgit diff --checkQA
Alice approved post-merge real Slack QA because this integration has no preview bot/environment. The frozen test is: rename a Slack-created record in Content, correct unrelated fields in the original Slack thread, and verify the same ID remains, the live title is preserved, no duplicate is created, and Slack posts one truthful confirmation.