From f0362f021d63ef9e685aebc17c21e404526734c6 Mon Sep 17 00:00:00 2001 From: Gang Wu Date: Thu, 16 Jul 2026 13:01:55 +0800 Subject: [PATCH 1/4] ci: enable ASF Copilot code review --- .asf.yaml | 4 ++++ .github/copilot-instructions.md | 21 +++++++++++++++++++++ 2 files changed, 25 insertions(+) create mode 100644 .github/copilot-instructions.md diff --git a/.asf.yaml b/.asf.yaml index 0c4f0276d..a76ba202e 100644 --- a/.asf.yaml +++ b/.asf.yaml @@ -53,6 +53,10 @@ github: - zhjwpku ghp_branch: gh-pages ghp_path: / + copilot_code_review: + enabled: true + review_drafts: false + review_on_push: true notifications: commits: commits@iceberg.apache.org diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md new file mode 100644 index 000000000..e4a8ef026 --- /dev/null +++ b/.github/copilot-instructions.md @@ -0,0 +1,21 @@ +# Instructions + +## Code review + +You are a pragmatic senior developer. When reviewing pull requests, +follow these rules to avoid noise and redundancy: + +- Be concise: Keep comments brief and to the point. Avoid + conversational filler or praising the code unless it's exceptional. +- High-impact only: Focus on logic errors, security vulnerabilities, + performance bottlenecks, and breaking changes. +- Skip the Obvious: Do not describe what the code is doing. Assume the + reader understands the code. +- Ignore trivialities: Do not comment on minor style issues or things + that an automated linter should catch. +- Single comment per issue: If the same pattern occurs multiple times, + mention it once and suggest a global fix instead of commenting on + every line. +- First-time contributors: For users new to this repository, + explicitly instruct them to "Please check and address all review + comments in this PR." From 787257054c39f043a1a5dd77147aa95c22efd633 Mon Sep 17 00:00:00 2001 From: Gang Wu Date: Fri, 17 Jul 2026 13:30:18 +0800 Subject: [PATCH 2/4] ci: exclude Copilot instructions from RAT --- dev/release/rat_exclude_files.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/dev/release/rat_exclude_files.txt b/dev/release/rat_exclude_files.txt index b8a1c098e..e095f9ada 100644 --- a/dev/release/rat_exclude_files.txt +++ b/dev/release/rat_exclude_files.txt @@ -17,6 +17,7 @@ .gitignore LICENSE +.github/copilot-instructions.md NOTICE build/** dist/** From d81dc5ead4b2b45de10cc7933d96a57d2dfe67ca Mon Sep 17 00:00:00 2001 From: Gang Wu Date: Fri, 17 Jul 2026 16:54:47 +0800 Subject: [PATCH 3/4] Apply suggestion from @wgtmac --- dev/release/rat_exclude_files.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev/release/rat_exclude_files.txt b/dev/release/rat_exclude_files.txt index e095f9ada..654197f05 100644 --- a/dev/release/rat_exclude_files.txt +++ b/dev/release/rat_exclude_files.txt @@ -16,8 +16,8 @@ # under the License. .gitignore -LICENSE .github/copilot-instructions.md +LICENSE NOTICE build/** dist/** From 297eac4871634d7d0fdcc25f1a3a58a63aebce73 Mon Sep 17 00:00:00 2001 From: Gang Wu Date: Fri, 17 Jul 2026 16:55:12 +0800 Subject: [PATCH 4/4] Apply suggestion from @wgtmac --- dev/release/rat_exclude_files.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev/release/rat_exclude_files.txt b/dev/release/rat_exclude_files.txt index 654197f05..9afe473d7 100644 --- a/dev/release/rat_exclude_files.txt +++ b/dev/release/rat_exclude_files.txt @@ -15,8 +15,8 @@ # specific language governing permissions and limitations # under the License. -.gitignore .github/copilot-instructions.md +.gitignore LICENSE NOTICE build/**