From f66094007534d70e43e7fd85d6a912fbd1f3e6bd Mon Sep 17 00:00:00 2001 From: Paul Bouchon Date: Mon, 20 Jul 2026 17:36:11 -0400 Subject: [PATCH] tools: fix shared-lib build on V8 cache miss The first `download-artifact` step in build-shared.yml does not name an artifact, so it downloads every artifact from the run. On a V8 cache miss the libv8 NAR is also present, and downloading multiple artifacts places each in its own directory, nesting the tarball one level deeper. `tar xzf tarballs/*.tar.gz` then matches a directory and fails. Set `merge-multiple: true` so the artifacts are flattened into `tarballs`, matching the single-artifact layout the extract step expects. The NAR is still downloaded separately by name for the V8 step. Fixes: https://github.com/nodejs/node/issues/64554 Signed-off-by: Paul Bouchon --- .github/workflows/build-shared.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build-shared.yml b/.github/workflows/build-shared.yml index 285834cf52e571..c7ee007f13ff38 100644 --- a/.github/workflows/build-shared.yml +++ b/.github/workflows/build-shared.yml @@ -39,6 +39,7 @@ jobs: - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 with: path: tarballs + merge-multiple: true - name: Extract tarball shell: bash