ARM: dts: qcom: revert back pmic-arb to the LEVEL trigger setting#1521
Open
raryan-qcom wants to merge 1 commit into
Open
ARM: dts: qcom: revert back pmic-arb to the LEVEL trigger setting#1521raryan-qcom wants to merge 1 commit into
raryan-qcom wants to merge 1 commit into
Conversation
Traditionally on all targets PMIC-ARB top-level IRQ (coming out from GIC to CPU) was LEVEL triggered. However, for Shikra target this had to be changed to EDGE, as the GIC input IRQ from the PMIC-ARB HW block was changed to EDGE by HW team. Without it, the input/output trigger type mismatch was leading to SPMI irqs not work. However, when the VDDMIN(APPS suspend) path was enabled, the USB detection was failing after VDDMIN exit. This was happening because during the VDDMIN exit, the IRQs are relayed from the MPM (rather than GIC), and when the exit happens, there is a window, where the IRQs were missed due to the EDGE trigger logic, by the GIC, and it appears because of that all the subsequent IRQs are missed. To fix this HW team has recommended to switch back to the LEVEL setting. So, add the needed DT change for it. Note - A corresponding change will be added in the TZ code as well, to make the PMIC-ARB -> GIC HW block LEVEL trigger. Change-Id: I907149dd3ce18ec4b10bf8874eaa18ae0faa87c5 Signed-off-by: Rakesh Kota <rakesh.kota@oss.qualcomm.com>
raryan-qcom
force-pushed
the
for-shikra-dt-level
branch
from
July 16, 2026 12:46
d4a1963 to
b4dcda2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Traditionally on all targets PMIC-ARB top-level IRQ (coming out from GIC to CPU) was LEVEL triggered. However, for Shikra target this had to be changed to EDGE, as the GIC input IRQ from the PMIC-ARB HW block was changed to EDGE by HW team.
Without it, the input/output trigger type mismatch was leading to SPMI irqs not work.
However, when the VDDMIN(APPS suspend) path was enabled, the USB detection was failing after VDDMIN exit. This was happening because during the VDDMIN exit, the IRQs are relayed from the MPM (rather than GIC), and when the exit happens, there is a window, where the IRQs were missed due to the EDGE trigger logic, by the GIC, and it appears because of that all the subsequent IRQs are missed.
To fix this HW team has recommended to switch back to the LEVEL setting. So, add the needed DT change for it.
Note - A corresponding change will be added in the TZ code as well, to make the PMIC-ARB -> GIC HW block LEVEL trigger.
Change-Id: I907149dd3ce18ec4b10bf8874eaa18ae0faa87c5