refactor(pyx-safe): naming, docs, dead code in the solver layer (D-14..22, WA-05..09, WA-18) by lmoresi · Pull Request #366 · underworldcode/underworld3

refactor(solvers): rename _maybe_install_snes_update -> _attach_snes_update_hook (D-14)

lmoresi

committed

chore(solvers): delete four unused imports (WA-08)

lmoresi

committed

fix(solvers): raise('string') -> TypeError/ValueError in four BC/section error paths (WA-05)

lmoresi

committed

fix(solvers): F1 guard property error message said F0 (D-17)

lmoresi

committed

refactor(solvers): delete two 'if True:' constant guards, dedent bodies (WA-06)

lmoresi

committed

chore(solvers): delete fossil commented-out code blocks (WA-07)

lmoresi

committed

refactor(solvers): explicit u_Field=None branches in Scalar/Vector constructors (D-15)

lmoresi

committed

refactor(solvers): dedent the byte-identical Picard/else Stokes solve tail (D-16)

lmoresi

committed

docs(solvers): document the hardcoded snes_max_it=50 clobber (D-22)

lmoresi

committed

refactor(solvers): one class-level SNES convergence-reason table for both consumers (D-18)

lmoresi

committed

refactor(solvers): one _nondimensional_time helper for the x6 verbatim copies (D-19)

lmoresi

committed

refactor(solvers): rename dim -> cdim where the local holds mesh.cdim (D-20)

lmoresi

committed

docs(solvers): TODO(DESIGN)-ify or delete unresolved editorial musings (D-21)

lmoresi

committed

refactor(solvers): remove reserved 'robust'/'fast' pass branches from the Stokes strategy setter (WA-09)

lmoresi

committed

chore(discretisation): delete dead petsc_dm_get_periodicity block; fix stray pprint positional proc (WA-18 + #344 follow-up)

lmoresi

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(pyx-safe): naming, docs, dead code in the solver layer (D-14..22, WA-05..09, WA-18)#366

refactor(pyx-safe): naming, docs, dead code in the solver layer (D-14..22, WA-05..09, WA-18)#366
lmoresi merged 15 commits into
developmentfrom
feature/pyx-safe

Commits on Jul 15, 2026

refactor(solvers): rename _maybe_install_snes_update -> _attach_snes_update_hook (D-14)

chore(solvers): delete four unused imports (WA-08)

fix(solvers): raise('string') -> TypeError/ValueError in four BC/section error paths (WA-05)

fix(solvers): F1 guard property error message said F0 (D-17)

refactor(solvers): delete two 'if True:' constant guards, dedent bodies (WA-06)

chore(solvers): delete fossil commented-out code blocks (WA-07)

refactor(solvers): explicit u_Field=None branches in Scalar/Vector constructors (D-15)

refactor(solvers): dedent the byte-identical Picard/else Stokes solve tail (D-16)

docs(solvers): document the hardcoded snes_max_it=50 clobber (D-22)

refactor(solvers): one class-level SNES convergence-reason table for both consumers (D-18)

refactor(solvers): one _nondimensional_time helper for the x6 verbatim copies (D-19)

refactor(solvers): rename dim -> cdim where the local holds mesh.cdim (D-20)

docs(solvers): TODO(DESIGN)-ify or delete unresolved editorial musings (D-21)

refactor(solvers): remove reserved 'robust'/'fast' pass branches from the Stokes strategy setter (WA-09)

chore(discretisation): delete dead petsc_dm_get_periodicity block; fix stray pprint positional proc (WA-18 + #344 follow-up)