Bound initial notification reads#989
Merged
raymondjacobson merged 1 commit intoJul 7, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SET LOCAL enable_seqscan = offfor candidate-limited notification reads, including unread polling.Why
limit=20and unreadlimit=0, not just timestamp pagination.notifications unread query timed outand 13notifications query timed outmessages.eJ57Dincludes giant groups: roughly 11.7ksave:4281:type:playlistrows and 12.3kfollow:51rows inside the newest candidate groups. Candidate rows alone were still too many for the full validation/aggregation stack.Live validation
eJ57Dreturned count 20 in ~0.6s.Product impact
Test plan
go test ./api -run ^'$'\n- Attemptedgo test ./api -run TestV1Notifications; blocked locally because the test DB atlocalhost:21300is not running.