Cell#2765
Open
yechielw wants to merge 2 commits into
Open
Conversation
bbedward
requested changes
Jul 16, 2026
| "%1 issue found", | ||
| "%1 issues found", | ||
| "%1 min left", | ||
| "%1 modem, none connected", |
Collaborator
There was a problem hiding this comment.
This file existed as a means to dis-allow new translations during a temporary freeze period, should not be edited in PRs. Its deleted on master now though so its a moot point, should rebase the PR
| @@ -7,6 +7,9 @@ type Backend interface { | |||
| GetWiFiEnabled() (bool, error) | |||
Collaborator
There was a problem hiding this comment.
Would like to see server.go APIVersion incremented, trivial though
| "icon": "dashboard" | ||
| }, | ||
| { | ||
| "section": "_tab_44", |
Collaborator
There was a problem hiding this comment.
This file is generated with script extract_settings_index.py , that should be ran to re-generate it
| connectionError = response.error; | ||
| lastConnectionError = response.error; | ||
| connectionStatus = "failed"; | ||
| ToastService.showError(I18n.tr("Failed to activate cellular connection"), response.error); |
Collaborator
There was a problem hiding this comment.
I thtink theres in general too many new translation terms here, I'd re-use whatever you can where its applicable.
|
@yechielw Linked related issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR was writin completly by codex
I have bean using it for a couple of weeks and it works perfect
it includs celluler options in quick settings, celluler indicator in the widget and celluler tab in the settings app
Type of change
Related issues
Screenshots / video
Checklist
I18n.tr()with translator context, reusing existing terms where possiblemake fmt, added/updated tests,make testpasses, andgo mod tidyis cleanmake lint-qmlwith no new warnings