feat(sdk-core): wire eddsaMPCv2Callbacks into generateWalletWithExternalSigner#9200
Draft
bitgo-ai-agent-dev[bot] wants to merge 1 commit into
Conversation
…nalSigner Add eddsaMPCv2Callbacks field to GenerateWalletWithExternalSignerOptions and add routing in generateMpcWalletWithExternalSigner to dispatch to EddsaMPCv2Utils.createKeychainsWithExternalSigner when the field is set. Changes: - iWallets.ts: add eddsaMPCv2Callbacks?: EddsaMPCv2KeyGenCallbacks to GenerateWalletWithExternalSignerOptions - wallets.ts: update hasMpcCallbacks to include eddsaMPCv2Callbacks; add an EdDSA MPCv2 branch that calls EddsaMPCv2Utils; guard against passing both eddsaMPCv2Callbacks and eddsaCallbacks simultaneously - walletsExternalSigner.ts: new test block covering routing to EddsaMPCv2Utils, mutual-exclusion rejection, no-callbacks rejection, and MPCv1 path unchanged verification Ticket: WCI-917 Session-Id: 23a5c77a-c909-407f-bf3e-a820c9e88aea Task-Id: 38b68db1-6599-4911-9635-d408663b0d82
Contributor
bitgo-ai-agent-dev
Bot
force-pushed
the
wci-917-wire-eddsampcv2callbacks-into-generate-wallet-with-external-signer
branch
from
7997d9a to
5a10bf9
Compare
Base automatically changed from
wci-894-define-eddsa-mpcv2-keygen-callback-types
to
master
July 8, 2026 06:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
eddsaMPCv2Callbacks?: EddsaMPCv2KeyGenCallbackstoGenerateWalletWithExternalSignerOptionsiniWallets.tshasMpcCallbacksinwallets.tsto includeeddsaMPCv2CallbackssocreateKeychainCallback+ MPCv2 callbacks is rejectedgenerateMpcWalletWithExternalSigner: dispatches toEddsaMPCv2Utils.createKeychainsWithExternalSignerwheneddsaMPCv2Callbacksis set; rejects if botheddsaMPCv2CallbacksandeddsaCallbacksare provided; falls through to the existing MPCv1 path otherwiseEddsaMPCv2Utils, mutual-exclusion rejection, no-callbacks rejection, MPCv1 path unchangedWhy
EddsaMPCv2KeyGenCallbackstype (WCI-894) into the external signer flow so consumers can opt into MPCv2 by passingeddsaMPCv2CallbacksDependencies
wci-894-define-eddsa-mpcv2-keygen-callback-typescontains theEddsaMPCv2KeyGenCallbackstype definitions (WCI-894)EddsaMPCv2Utils.createKeychainsWithExternalSigneris added by WCI-916; the implementation uses anas anycast until that lands and the type annotation will resolve when these branches are merged togetherTest plan
walletsExternalSigner.tspassgenerateWalletWithExternalSigner - EdDSA MPCv2 TSSdescribe block (7 tests) all passeddsaMPCv2Callbacksroutes toEddsaMPCv2Utils.createKeychainsWithExternalSignerwith correct paramseddsaMPCv2Callbacks+eddsaCallbackstogether is rejectededdsaCallbacksstill routes to the MPCv1EddsaUtilspath (not MPCv2)createKeychainCallback+eddsaMPCv2Callbackstogether is rejectedTicket: WCI-917