Conversation
mneedham
approved these changes
Jul 16, 2026
There was a problem hiding this comment.
Pull request overview
Adds an S3 “rolling feed” mechanism for the hits_100B realtime ingest benchmark, letting you continuously copy Parquet files into a destination bucket at a controlled effective ingest rate (rows/sec), plus the accompanying consumer-side ClickHouse table DDL.
Changes:
- Added
rolling_s3_copy.pyto pace server-side S3→S3 copies to a target--eps, with optional looping and periodic throughput summaries. - Added
_s3_ingest/INGEST.mdand_call.txtwith setup and operational steps for running the feeder and pointing consumers at the destination bucket. - Added
clickhouse-cloud/create.sqldefining thehitstable schema for ClickHouse Cloud.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| full-path-realtime/hits/clickhouse-cloud/create.sql | Adds ClickHouse table DDL for ingesting the hits_100B feed. |
| full-path-realtime/hits/_s3_ingest/rolling_s3_copy.py | Adds the rolling, rate-controlled S3 copy feeder script. |
| full-path-realtime/hits/_s3_ingest/INGEST.md | Documents prerequisites and how to run the feeder and configure consumers. |
| full-path-realtime/hits/_s3_ingest/_call.txt | Adds a quick command checklist for manual runs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+55
to
+57
| import boto3 | ||
| from boto3.s3.transfer import TransferConfig | ||
|
|
Comment on lines
+112
to
+116
| if args.eps <= 0: | ||
| sys.exit("--eps must be positive") | ||
|
|
||
| interval = args.rows_per_file / args.eps | ||
| total_files = args.num_files - args.start_index |
Comment on lines
+172
to
+178
| t0 = time.time() | ||
| s3.copy( | ||
| {"Bucket": args.source_bucket, "Key": src_key}, | ||
| args.dest_bucket, | ||
| dest_key, | ||
| Config=transfer_config, | ||
| ) |
| s3://public-pme/hits_100B/2000x50m_span_27h46m40s_rps_1m/hits_p00000.parquet \ | ||
| s3://public-pme/hits_100B_feed/hits_p00000.parquet | ||
|
|
||
| - (3) Create the pipeline - initial load ingests the real 50M rows from file 0 - wait until that happened... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.