fix: prevent SSRF via JSON import handlers#1331
Open
Alexia-Soare wants to merge 1 commit into
Open
Conversation
The `getJsonRoots()` and `getJsonData()` AJAX handlers verified only a
nonce before fetching a user-supplied URL server-side, and the fetch used
the unsafe `wp_remote_request()`. A Contributor (edit_posts) could read the
nonce from the chart editor and make WordPress fetch arbitrary internal
URLs, with the response reflected back (non-blind SSRF).
- Add a `current_user_can( 'edit_posts' )` guard to both handlers, matching
the sibling AJAX handlers in the file.
- Switch `Visualizer_Source_Json::connect()` to `wp_safe_remote_request()`,
matching the SSRF-safe transport already used by the CSV/remote path.
- Add regression tests covering the capability guard and safe transport.
Fixes Codeinwp/visualizer-pro#591
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Alexia-Soare
added
the
pr-checklist-skip
pirate-bot
added
the
pr-checklist-complete
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a server-side request forgery (SSRF) in the JSON import feature. Related issue: https://github.com/Codeinwp/visualizer-pro/issues/591
The
getJsonRoots()andgetJsonData()AJAX handlers verified only a nonce before fetching a user-supplied URL server-side, and the fetch used the unsafewp_remote_request(). Because the chart editor is gated byedit_postsand localizes the JSON nonces, a Contributor-level user could read the nonce and make WordPress fetch arbitrary internal URLs (127.0.0.1, private ranges, etc.), with the response reflected back inroots/table— a non-blind SSRF.The CSV/remote path already does this correctly (
wp_safe_remote_get()+wp_http_validate_url()); only the JSON source was left on the raw transport.Changes
classes/Visualizer/Module/Chart.php— add acurrent_user_can( 'edit_posts' )guard togetJsonRoots()andgetJsonData(), matching the sibling AJAX handlers in the file.classes/Visualizer/Source/Json.php— switchconnect()fromwp_remote_request()towp_safe_remote_request(), matching the SSRF-safe transport used by the CSV path.tests/test-ajax.php— three regression tests: access-control guard on both handlers, and confirmation the JSON source fetches through the safe transport (reject_unsafe_urls).Testing
OK (3 tests, 10 assertions)) and fail on the unpatched code (verified by reverting), so they genuinely detect the vulnerability.phpcspasses clean on all changed files.