refactor(common): decouple ConfigHttpServer from Swing dialogs#247
Draft
toku-sa-n wants to merge 3 commits into
Draft
refactor(common): decouple ConfigHttpServer from Swing dialogs#247toku-sa-n wants to merge 3 commits into
toku-sa-n wants to merge 3 commits into
Conversation
toku-sa-n
force-pushed
the
refactor/config-http-server-decouple
branch
4 times, most recently
from
7d8a334 to
f0d292f
Compare
Extract config overwrite UI into ConfigHttpUiActions and DB apply logic into ConfigSettingsWriter. Co-authored-by: Cursor <cursoragent@cursor.com>
Add Apache 2.0 copyright headers to ConfigHttpUiActions and ConfigSettingsWriter. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace duplicated private DaoHub inner classes in ConfigHttpServer, ConfigSettingsWriter, and ConfigIO with a shared DTO type. Co-authored-by: Cursor <cursoragent@cursor.com>
toku-sa-n
force-pushed
the
refactor/config-http-server-decouple
branch
from
f0d292f to
3b6c621
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UIとロジックコードの分離の第一歩として、PacketProxyHubから設定をダウンロードする際に使用する
ConfigHttpServerのロジック部分とUI部分を分離しました。