Skip to content

Use tenant message metadata for registration role notifications#901

Open
Vinod-V3 wants to merge 1 commit into
ELEVATE-Project:developfrom
Vinod-V3:login-enhancement
Open

Use tenant message metadata for registration role notifications#901
Vinod-V3 wants to merge 1 commit into
ELEVATE-Project:developfrom
Vinod-V3:login-enhancement

Conversation

@Vinod-V3

@Vinod-V3 Vinod-V3 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Updated registration email and SMS notifications to populate variables.roles from tenantDetail.meta?.message, falling back to roleToString.
  • Improves tenant-specific role/message display while preserving the existing fallback behavior.

Impact and risk

  • Limited runtime impact to registration notification content.
  • No API contract, authentication/security, database migration, background worker/queue, environment/configuration, or external integration changes.
  • API documentation, migration files, and environment samples were not expected to change for this implementation.
  • Rollback: revert the change to restore roleToString-only notification values.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0c8cd88d-0da0-4030-a07d-843f8edbd0dc

📥 Commits

Reviewing files that changed from the base of the PR and between c2263ae and 66ca74d.

📒 Files selected for processing (1)
  • src/services/account.js
📜 Recent review details
🧰 Additional context used
📓 Path-based instructions (1)
src/services/**

⚙️ CodeRabbit configuration file

This is core business logic. Please check for correctness, efficiency, and potential edge cases.

Files:

  • src/services/account.js
🔇 Additional comments (1)
src/services/account.js (1)

647-647: LGTM!

Also applies to: 663-663


Walkthrough

Registration email and SMS notifications now prefer tenantDetail.meta?.message for variables.roles, falling back to roleToString.

Changes

Registration notification role messages

Layer / File(s) Summary
Role message fallback
src/services/account.js
Registration email and SMS templates use the tenant metadata message for variables.roles, with roleToString as fallback.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

I’m a rabbit with a message to share,
Roles now carry tenant words with care.
Email hops, SMS sings,
Fallback text gives both their wings.
Thump, thump—notifications bloom!

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title Check ✅ Passed Title check skipped as CodeRabbit has written the PR title.
Api Docs Updated ✅ Passed Only notification template variables changed in src/services/account.js; no API-layer or src/api-doc updates, so no public contract change.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot changed the title @coderabbitai Use tenant message metadata for registration role notifications Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant