Refactor example CI setup.#437
Merged
Merged
Conversation
This change: - Adds many more `build_test` targets to ensure non-tests will still be built and checked. - Some of these are not working and are currently disabled. - Splits each top-level package into a separate CI action so that it's easier to spot failures and ensure other tests continue - Adds a new tag-based way to disable tests: - `no-ci` will skip the test in CI entirely - `no-remote-ci` and `no-local-ci` will skip based on remote execution - `no-linux-ci` and `no-macos-ci` will skip based on the OS
mbland
approved these changes
Jul 8, 2026
mbland
left a comment
mbland
left a comment
Contributor
There was a problem hiding this comment.
LGTM, though I have a few questions and suggestions to consider before merging. Nothing ultimately blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change:
build_testtargets to ensure non-tests will still be built and checked.no-ciwill skip the test in CI entirelyno-remote-ciandno-local-ciwill skip based on remote executionno-linux-ciandno-macos-ciwill skip based on the OS