Skip to content

Docs updates for E/A#95483 date-bound distance rate editable settings#96049

Open
MelvinBot wants to merge 1 commit into
mainfrom
claude-docsDateBoundMileageRate
Open

Docs updates for E/A#95483 date-bound distance rate editable settings#96049
MelvinBot wants to merge 1 commit into
mainfrom
claude-docsDateBoundMileageRate

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

#95483 removes the dateBoundMileageRate beta gate, releasing date-bound (Start date / End date) distance rates to everyone. The help site article Set Distance Rates already documented adding a rate with a Start date and End date and how rates are selected by expense date, but the How to edit Distance rate settings section did not list Start date and End date as editable settings — even though those rows are now shown and editable on the rate details page for all users.

Changes

  • Added Start date and End date to the list of editable settings under How to edit Distance rate settings.
  • Fixed a typo (a dDistance expensea Distance expense) in the rate-selection section.

UI labels verified against src/languages/en.ts (Start date, End date).

Related


@rlinoz, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

Co-authored-by: Rodrigo Lino da Costa <rlinoz@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jul 14, 2026
@MelvinBot MelvinBot mentioned this pull request Jul 14, 2026
52 tasks
@rlinoz rlinoz marked this pull request as ready for review July 14, 2026 12:23
@rlinoz rlinoz requested a review from stephanieelliott as a code owner July 14, 2026 12:23
Comment on lines +45 to +46
- Start date
- End date

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming/UI consistency: Start date and End date are exact UI labels and are bolded everywhere else in this article (e.g., steps under How to add Distance rates and the rate-selection section). For consistency with the Core UI Referencing / exact-label conventions, bold them here too:

Suggested change
- Start date
- End date
- **Start date**
- **End date**

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment
This PR makes two small, well-scoped edits to docs/articles/new-expensify/workspaces/Set-distance-rates.md in support of releasing date-bound distance rates (removal of the dateBoundMileageRate beta gate). It adds Start date and End date to the list of editable settings under How to edit Distance rate settings, and corrects a typo (a dDistance expense becomes a Distance expense) in the rate-selection section. The changes accurately reflect current product behavior and keep the article consistent with the rest of the page.

Scores Summary

  • Readability: 10/10 - The added list items are consistent with the existing settings list, and the typo fix improves clarity. No flow or scannability concerns.
  • AI Readiness: 10/10 - Changes reuse UI-exact labels (Start date, End date), reinforce existing task-based headings, and do not disturb metadata or heading hierarchy.
  • Style Compliance: 10/10 - Field labels match the UI (verified against src/languages/en.ts), bold formatting is applied to UI labels, and terminology (Distance, Workspace, member) follows the naming conventions.

Key Findings

  • The typo fix (dDistance becomes Distance) corrects a genuine defect in the previously published content and improves retrieval and readability.
  • Adding Start date and End date to the editable-settings list closes a documentation gap: these rows are now shown and editable for all users, so the list now matches actual behavior.
  • Both additions are consistent with the article existing terminology, bolding, and list style; no new style deviations introduced.
  • Scope is tightly controlled (3 additions, 1 deletion), staying within the single documented workflow.

Recommendations

  • No blocking changes required. The diff is compliant with all three governance documents.
  • Minor optional consideration (not introduced by this PR, so out of scope): the article intermittently uses Distance Rates vs Distance rates casing; a future pass could align casing across the page against the exact UI label.

Files Reviewed

  • docs/articles/new-expensify/workspaces/Set-distance-rates.md - Approved. Two accurate, in-scope edits that align documentation with current behavior.

Note: This PR is small and self-contained; the findings above cover the full diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants