[Hold Web-E#54516] Add clickable metadata support to embedded Victory bar charts#96065
Draft
inimaga wants to merge 10 commits into
Draft
[Hold Web-E#54516] Add clickable metadata support to embedded Victory bar charts#96065inimaga wants to merge 10 commits into
inimaga wants to merge 10 commits into
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Held on https://github.com/Expensify/Web-Expensify/pull/54516
Explanation of Change
This PR adds per-point metadata parsing for embedded Victory chart data, preserving
labelandsearchQueryfields and carrying them through the Victory chart renderer context.Vertical embedded bar charts should now show web hover tooltips from that metadata and navigate to Search when a bar has a
searchQuery.Fixed Issues
$ #92149
PROPOSAL: N/A
Tests
Automated Tests
Covered by added automated tests
Manual Test
Pre-requisite (Skip to Test Steps if testing in Staging/Prod):
Test Steps:
<< Video to be added >>
Offline tests
QA Steps
Same as manual test steps above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari