[NO QA] Add BrowserStack Automate uploads using 1Password#96097
Closed
roryabraham wants to merge 1 commit into
Closed
[NO QA] Add BrowserStack Automate uploads using 1Password#96097roryabraham wants to merge 1 commit into
roryabraham wants to merge 1 commit into
Conversation
Load BROWSERSTACK_AUTOMATE from the Mobile-Deploy-CI vault via load-secrets-action instead of a GitHub secret, and upload Android and iOS builds to BrowserStack App Automate during deploy. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added commands to upload builds to BrowserStack Automate, loading credentials from the
BROWSERSTACK_AUTOMATEsecure note in theMobile-Deploy-CI1Password vault viaload-secrets-actioninstead of a GitHub secret.Explanation of Change
Adds Android and iOS BrowserStack App Automate upload steps to the deploy workflow. Credentials are loaded from 1Password (
op://Mobile-Deploy-CI/BROWSERSTACK_AUTOMATE/notesPlain) using the sameload-secrets-actionpattern as the Applause upload jobs, so no new GitHub secret provisioning is required.Supersedes Add upload steps for Android and iOS to BrowserStack Automate.
Fixed Issues
$ #94368
PROPOSAL:
Tests
Upload Android to BrowserStackandUpload iOS to BrowserStackjobs complete successfully.Offline tests
NO QA
QA Steps
NO QA
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A - workflow-only change
Android: mWeb Chrome
N/A - workflow-only change
iOS: Native
N/A - workflow-only change
iOS: mWeb Safari
N/A - workflow-only change
MacOS: Chrome / Safari
N/A - workflow-only change