[HOLD auth 22883] Add REGISTER_AUTHENTICATION_KEY reasonCode#96114
[HOLD auth 22883] Add REGISTER_AUTHENTICATION_KEY reasonCode#96114chuckdries wants to merge 2 commits into
Conversation
…-register-authentication-key
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a21850c10f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (!validateCode) { | ||
| addMFABreadcrumb('Validate code requested'); | ||
| requestValidateCodeAction(); | ||
| requestValidateCodeAction({reasonCode: COMMON_CONST.VALIDATE_CODE_REASONS.REGISTER_AUTHENTICATION_KEY}); |
There was a problem hiding this comment.
Bump expensify-common before using the new reason
This new reason is not available in the dependency version this repo installs: package.json and package-lock.json still pin expensify-common to 2.0.191, while REGISTER_AUTHENTICATION_KEY is being added in the separate expensify-common PR referenced by this change. With a clean install of this commit, COMMON_CONST.VALIDATE_CODE_REASONS.REGISTER_AUTHENTICATION_KEY is missing, so the MFA registration path will fail to build/typecheck or evaluate this access until the package is bumped to a published version containing that constant.
Useful? React with 👍 / 👎.
Explanation of Change
Also depends on Expensify/expensify-common#930
Pass
reasonCode: REGISTER_AUTHENTICATION_KEYwhen requesting a validate code for registering biometrics or passkeysFixed Issues
For https://github.com/Expensify/Expensify/issues/623748
PROPOSAL:
Tests
Biometrics, if it says(Registered), press "Revoke"Biometrics, pressTestSet up biometrics or a passkey for your Expensify accountnear the topSet up biometrics or a passkey for your Expensify accountOffline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos