Ticket8858 regroup checkboxes#1859
Open
advait-nair-ral wants to merge 9 commits into
Open
Conversation
| // checkboxSearch.setLayoutData(new GridData(SWT.END, SWT.CENTER, false, | ||
| // false)); | ||
| // checkboxSearch.addModifyListener(e -> | ||
| // filterCheckboxes(checkboxSearch.getText())); |
There was a problem hiding this comment.
If this commented out code isn't going to be used, it should be removed
…vait-nair-ral/ibex_gui into Ticket8858_Regroup_Checkboxes
Appears that some JavaDoc comments were not updated when the structure was ported from another section. This has been solved and the test should hopefully pass now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
I have added (commit: Needs to be split into more granular groups):
Amy has added (commit: search bar implementation):
Ticket
ISISComputingGroup/IBEX#8858
Acceptance criteria
System tests
No tests have been implemented with Squish or added in Eclipse. Existing tests in Eclipse are passing but new tests regarding the search and category functionality have not been added. Possible tests:
Warning
Documentation
N/A
Code Review
check_opi_format.pyscript in C:\Instrument\Dev\ibex_gui\base\uk.ac.stfc.isis.ibex.opis pass?Final Steps