Skip to content

Ticket8858 regroup checkboxes#1859

Open
advait-nair-ral wants to merge 9 commits into
ISISComputingGroup:masterfrom
advait-nair-ral:Ticket8858_Regroup_Checkboxes
Open

Ticket8858 regroup checkboxes#1859
advait-nair-ral wants to merge 9 commits into
ISISComputingGroup:masterfrom
advait-nair-ral:Ticket8858_Regroup_Checkboxes

Conversation

@advait-nair-ral

@advait-nair-ral advait-nair-ral commented Jul 15, 2026

Copy link
Copy Markdown

Description of work

I have added (commit: Needs to be split into more granular groups):

  • Fields for journal table are now grouped by relevant categories (new file: JournalFieldCategoriser.java)
  • Field Enums now have an assigned Category Enum
  • Category Enums for fields, which have a title and description/tooltip

Amy has added (commit: search bar implementation):

  • Added search implementation for fields
  • Grey-out checkboxes on search hit for easy field pinpointing
  • Reorganisation into granular groups by adding more Enum Categories

Ticket

ISISComputingGroup/IBEX#8858

Acceptance criteria

  • The fields in the journal viewer (the checkboxes) are displayed or grouped in a more logical or more user-friendly way

System tests

No tests have been implemented with Squish or added in Eclipse. Existing tests in Eclipse are passing but new tests regarding the search and category functionality have not been added. Possible tests:

  • Search character and length validation test
  • Ensure all JournalFields are assigned to a category with a valid Enum
  • Ensure search spans all checkboxes and columns

Warning

  • Pre-commit hook was bypassed with --no-verify.
  • No tests have been implemented with Squish or added in Eclipse.

Documentation

N/A

Code Review

Final Steps

@Spencer-Cheverton Spencer-Cheverton self-assigned this Jul 15, 2026
@Spencer-Cheverton
Spencer-Cheverton self-requested a review July 15, 2026 14:03
@Spencer-Cheverton Spencer-Cheverton removed their assignment Jul 15, 2026
Comment thread base/uk.ac.stfc.isis.ibex.ui.journalviewer/META-INF/MANIFEST.MF Outdated
// checkboxSearch.setLayoutData(new GridData(SWT.END, SWT.CENTER, false,
// false));
// checkboxSearch.addModifyListener(e ->
// filterCheckboxes(checkboxSearch.getText()));

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this commented out code isn't going to be used, it should be removed

AmyW-RAL and others added 3 commits July 17, 2026 16:04
Appears that some JavaDoc comments were not updated when the structure was ported from another section. This has been solved and the test should hopefully pass now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants