Skip to content

Move build comments to dedicated page#3846

Merged
josephsnyder merged 1 commit into
Kitware:masterfrom
williamjallen:build-comments-page
Jul 9, 2026
Merged

Move build comments to dedicated page#3846
josephsnyder merged 1 commit into
Kitware:masterfrom
williamjallen:build-comments-page

Conversation

@williamjallen

Copy link
Copy Markdown
Collaborator

Comments are currently displayed on the build summary page. With the recent shift in focus for the build summary page, it no longer makes sense to display the comments there. This PR moves the comments to a dedicated page, freeing up space on the build summary page for more charts and summary cards.

image

@josephsnyder josephsnyder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New page looks good. No issues with functionality once in the Build page. However, the comment bubble link on the project page wasn't updated and still links to the Build Summary part of the page:

Image

And as a bit of future work, do we want to standardize the Comment icon? This is the first time, I think, that we have an icon to take you directly to a part of the build instead of a text link.

@williamjallen williamjallen force-pushed the build-comments-page branch from 5239a62 to c84260b Compare July 9, 2026 19:42
@williamjallen

Copy link
Copy Markdown
Collaborator Author

@josephsnyder

However, the comment bubble link on the project page wasn't updated and still links to the Build Summary part of the page

Good catch. Fixed.

And as a bit of future work, do we want to standardize the Comment icon? This is the first time, I think, that we have an icon to take you directly to a part of the build instead of a text link.

The index page uses Glyphicon icons from Bootstrap, while everything in the Vue portion of the site uses Font Awesome. Eventually the index page will be converted to Vue, and I plan to use the same icons across the board.

@josephsnyder josephsnyder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! LGTM!

@josephsnyder josephsnyder enabled auto-merge July 9, 2026 20:15
@josephsnyder josephsnyder added this pull request to the merge queue Jul 9, 2026
Merged via the queue into Kitware:master with commit d180997 Jul 9, 2026
19 of 21 checks passed
@williamjallen williamjallen deleted the build-comments-page branch July 10, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants