Show time on all clinical history data sources#720
Merged
Conversation
Add setShowTime(true) to the 18 history data source constructors that were missing it, and flip the explicit row.setShowTime(false) calls to true in NIRCObservationsDataSource and NIRCObservationOrdersDataSource, whose custom processRows overrides bypass the constructor flag (this also covers the behavior and clinical observation subclasses). Every source already selects its date field (date, or enddate where getDateField() is overridden) and AbstractDataSource reads it via getTimestamp(), so the time component is available for display.
labkey-bpatel
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Clinical History was showing only the date on most record types, even though the underlying datasets store full timestamps. Showing the time makes it possible to see the order of same-day clinical events (observations, drug administrations, case activity, etc.) in the Clinical History panel.
Related Pull Requests
None.
Changes
setShowTime(true)to the 18 history data source constructors that were missing it.row.setShowTime(false)calls totrueinNIRCObservationsDataSourceandNIRCObservationOrdersDataSource, whose customprocessRowsoverrides bypass the constructor flag; this also covers the behavior and clinical observation subclasses.date, orenddatewheregetDateField()is overridden) andAbstractDataSourcereads it viagetTimestamp(), so the time component is available for display.