Make post topic optional#29
Merged
Merged
Conversation
|
Tip |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Topics are no longer mandatory. A post can belong to a topic hub or stand alone.
Schema:
topicIdis now optional (z.enum(...).optional()). Frontmatter for existing posts is unchanged.What a topicless post keeps: /blog archive, on-site search, tag pages, author page, RSS, Google, and "related" strips (via shared tags). What it opts out of:
/topics/<x>hub pages and topic chips — exactly the point.Guards added at every
topicIdread site so nothing renders an empty chip or breaks:countPostsByTopic,topicName(undefined)undefined === undefined)Editor: topic selector labeled "optional" with a "No specific topic" choice; the hard "Pick a topic" validation is removed; the serializer omits
topic/topicIdfrontmatter when none is chosen. (Proposing a new topic was already supported viaproposedTopic.)Verified: built with a real topicless post — appears in /blog with no empty chip, absent from all /topics hubs, build green. Added a serializer test for the omitted-topic case (62 tests pass).