Fix BetterChat anti-spam Network Protocol Error#6508
Open
yesidodo73 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Fixed a BetterChat anti-spam issue that could cause a Network Protocol Error and disconnect when duplicate chat messages were merged while the chat line state was out of sync.
BetterChat previously removed visible chat lines manually using cached line counts when anti-spam merged a duplicate message. If the cached line count no longer matched the actual trimmed chat list, it could try to remove an invalid index during system chat packet handling, causing Minecraft to show a Network Protocol Error and disconnect from the server.
After removing the duplicate message from chat history, BetterChat now refreshes the trimmed chat messages through Minecraft's normal refresh path instead of manually removing visible lines by index.
Related issues
None
How Has This Been Tested?
Tested by sending duplicate chat messages with BetterChat anti-spam enabled and confirming that duplicate messages are merged without causing a Network Protocol Error or disconnect.
Checklist: