Cardinal Semiotic Class for Tamil ITN#452
Conversation
Signed-off-by: retheckj <retheckj@nvidia.com>
Signed-off-by: retheckj-star <retheckj@nvidia.com>
Signed-off-by: retheckj-star <retheckj@nvidia.com>
folivoramanh
left a comment
folivoramanh
left a comment
There was a problem hiding this comment.
add init into data/numbers
add sparrowhawk file and run sh test (we need to make sure both pytest and sparrowhawk pass)
add ta to jenkins file
There was a problem hiding this comment.
do not publish blind test case to here
There was a problem hiding this comment.
only add your language, do not modify the code
There was a problem hiding this comment.
remove this file, and we have run_evaluate to run blind test
There was a problem hiding this comment.
if it's a null file, please remove
| graph = ( | ||
| pynutil.delete('integer: "') | ||
| + pynini.closure( | ||
| pynini.union("௦", "௧", "௨", "௩", "௪", "௫", "௬", "௭", "௮", "௯", " ", "இ", "ன்", "ல்"), |
There was a problem hiding this comment.
why we hardcoded in here?
|
|
||
| graph_digit = pynini.string_file(get_abs_path("data/numbers/digit.tsv")) | ||
|
|
||
| NEMO_TA_DIGIT = pynini.union("௦", "௧", "௨", "௩", "௪", "௫", "௬", "௭", "௮", "௯").optimize() |
There was a problem hiding this comment.
we have numbers/digit.tsv why we need additional NEMO_TA_DIGIT?
| graph_digit = pynini.string_file(get_abs_path("data/numbers/digit.tsv")) | ||
|
|
||
| NEMO_TA_DIGIT = pynini.union("௦", "௧", "௨", "௩", "௪", "௫", "௬", "௭", "௮", "௯").optimize() | ||
| TAMIL_DIGIT = ["௦", "௧", "௨", "௩", "௪", "௫", "௬", "௭", "௮", "௯"] |
There was a problem hiding this comment.
data/numbers/digit.tsv?
| @@ -1,4 +1,4 @@ | |||
| # Copyright (c) 2021, NVIDIA CORPORATION. All rights reserved. | |||
| # Copyright (c) 2026, NVIDIA CORPORATION. All rights reserved. | |||
2 participants
What does this PR do ?
This PR is for the Tamil ITN Cardinal Semiotic Class.
Before your PR is "Ready for review"
Pre checks:
git commit -sto sign.pytestor (if your machine does not have GPU)pytest --cpufrom the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...pytestand Sparrowhawk here.__init__.pyfor every folder and subfolder, includingdatafolder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.to all newly added Python files?Copyright 2015 and onwards Google, Inc.. See an example here.try import: ... except: ...) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.