Ko TN: Add serial grammar and review fixes

[bbae0312]

What does this PR do ?

Adds Korean TN serial grammar support for number-like strings with clear context signals such as 번호 and 연락처.

Before your PR is "Ready for review"

Pre checks:

• Have you signed your commits? Use git commit -s to sign.
• Do all unittests finish successfully before sending PR?
  1. pytest or (if your machine does not have GPU) pytest --cpu from the root folder (given you marked your test cases accordingly @pytest.mark.run_only_on('CPU')).
  2. Sparrowhawk tests bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
• If you are adding a new feature: Have you added test cases for both pytest and Sparrowhawk here.
• Have you added __init__.py for every folder and subfolder, including data folder which has .TSV files?
• Have you followed codeQL results and removed unused variables and imports (report is at the bottom of the PR in github review box) ?
• Have you added the correct license header Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. to all newly added Python files?
• If you copied nemo_text_processing/text_normalization/en/graph_utils.py your header's second line should be Copyright 2015 and onwards Google, Inc.. See an example here.
• Remove import guards (try import: ... except: ...) if not already done.
• If you added a new language or a new feature please update the NeMo documentation (lives in different repo).
• Have you added your language support to tools/text_processing_deployment/pynini_export.py.

PR Type:

• New Feature
• Bugfix
• Documentation
• Test

If you haven't finished some of the above items you can still open "Draft" PR.

[tbartley94]

Serial appears more appropriate as part of the cardinal class no? What's the rationale for a standalone class?

[tbartley94]

change copyright

[bbae0312]

fixed

[tbartley94]

don't believe serial is sparrowhawk compliant no?

[tbartley94]

is there no issue with potential 0 leading strings?

[tbartley94]

from what i'm seeing is that this is just replacing a single korean character. couldn't you compress the three together for simplicity?

[bbae0312]

Serial appears more appropriate as part of the cardinal class no? What's the rationale for a standalone class?

I made it standalone because the digit-by-digit reading is triggered by context such as 번호 or 연락처, while regular numbers should remain standard cardinal readings. I agree the numeric logic is closer to cardinal, though. Would you prefer that I move it into CardinalFst and remove the standalone class?

[tbartley94]

Serial appears more appropriate as part of the cardinal class no? What's the rationale for a standalone class?

I made it standalone because the digit-by-digit reading is triggered by context such as 번호 or 연락처, while regular numbers should remain standard cardinal readings. I agree the numeric logic is closer to cardinal, though. Would you prefer that I move it into CardinalFst and remove the standalone class?

Take a gander if it's feasible to just make it in Cardinals and work from there. If it's too messy then we can keep it. I'm just trying to limit semiotic spread

[bbae0312]

Serial appears more appropriate as part of the cardinal class no? What's the rationale for a standalone class?

I made it standalone because the digit-by-digit reading is triggered by context such as 번호 or 연락처, while regular numbers should remain standard cardinal readings. I agree the numeric logic is closer to cardinal, though. Would you prefer that I move it into CardinalFst and remove the standalone class?

Take a gander if it's feasible to just make it in Cardinals and work from there. If it's too messy then we can keep it. I'm just trying to limit semiotic spread

Sounds good. I’ll see if I can integrate it into the cardinal class cleanly and push the update. If it gets too messy, I’ll let you know.