Skip to content

feat(ios): swift package clarity while installing and time formatting#6082

Merged
NathanWalker merged 1 commit into
mainfrom
feat/spm-ux-clarity
Jul 6, 2026
Merged

feat(ios): swift package clarity while installing and time formatting#6082
NathanWalker merged 1 commit into
mainfrom
feat/spm-ux-clarity

Conversation

@NathanWalker

@NathanWalker NathanWalker commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Refines how Swift Package Manager (SPM) activity messages are displayed and tested, making them more consistent and user-friendly.

Summary by CodeRabbit

  • Improvements
    • The Swift package dependency progress display now shows cleaner elapsed times in minutes and seconds.
    • Package resolution activity messages are now more consistent, and when possible include the package name in parentheses.
    • Log parsing now handles package fetch and clone messages more gracefully when no package reference is available.

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 727d18f5-5282-444e-ba72-4fa3f16a05e0

📥 Commits

Reviewing files that changed from the base of the PR and between 1cd151d and e3d6a80.

📒 Files selected for processing (2)
  • lib/services/ios/spm-service.ts
  • test/spm-service.ts

📝 Walkthrough

Walkthrough

Refactors SwiftPM dependency resolution progress display and activity parsing in spm-service.ts: elapsed time now renders via a new formatElapsed helper, and Fetching/Cloning log lines use a new describePackageActivity helper. shortenPackageRef now returns null instead of a default string when no reference is found. Tests updated accordingly.

Changes

SPM activity and elapsed-time formatting

Layer / File(s) Summary
Elapsed-time and package activity helpers
lib/services/ios/spm-service.ts
Adds formatElapsed for minutes/seconds display in spinner status, adds describePackageActivity to build " Swift Packages (…)" labels, and changes shortenPackageRef to return null when no URL/package reference is present.
Test coverage for formatting changes
test/spm-service.ts
Updates assertions for parenthesized package names in describeSPMActivity, null return from shortenPackageRef, and adds new formatElapsed test cases.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: triniwiz

Poem

A rabbit watched the packages spin,
Seconds and minutes, ticking within,
"Fetching" and "Cloning" now wear a name,
Null instead of guesses, tidier code, less shame,
Hop, hop, hooray for cleaner SPM flow! 🐇⏱️

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: clearer Swift Package Manager activity messages and improved elapsed-time formatting during install.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@NathanWalker NathanWalker merged commit e027862 into main Jul 6, 2026
5 checks passed
@NathanWalker NathanWalker deleted the feat/spm-ux-clarity branch July 6, 2026 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants