ABF1: read 2-digit-year (YYMMDD) acquisition dates correctly#1872
Open
h-mayorquin wants to merge 1 commit into
Open
ABF1: read 2-digit-year (YYMMDD) acquisition dates correctly#1872h-mayorquin wants to merge 1 commit into
h-mayorquin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found another bug @zm711
PR #1870 started reading the real acquisition date from
lFileStartDatein ABF (Axon Binary Format) version 1 files, assuming that field is always packed as YYYYMMDD but older ABF version 1 files pack it as YYMMDD with a 2-digit year instead, so a file storing180618came back as year 18 rather than 2018-06-18. This handles both packings.