feat: add UK Open Banking Read/Write v4.0.1 support#2862
Merged
Conversation
Adds code.api.UKOpenBanking.v4_0_1, mirroring the existing v3_1_0 http4s implementation: a ScannedApis marker (OBP_UKOpenBanking_401), an aggregator, and one endpoint object per sub-API (account-info, payment-initiation, confirmation-funds, event-notifications, events, vrp). 89 endpoints total, generated from the official read-write-api-specs v4.0.1 OpenAPI files. Since those specs carry no response examples (only $ref'd schemas), each endpoint returns an example synthesized from its schema rather than real connector data; every endpoint requires authentication via ResourceDocMiddleware. Wiring: new ScannedApiVersion in ApiVersion.scala, route mount in Http4sApp.baseServices, resource-doc aggregation in APIUtil, and the UK proprietary license clause in SwaggerJSONFactory. Adds a matching test suite (code.api.UKOpenBanking.v4_0_1, 178 scenarios across 6 classes) following the v3_1_0 pattern: unauthenticated requests assert 401, authenticated requests assert the deterministic success code for each endpoint's http4s helper (GET 200 / POST,PUT,PATCH 201 / DELETE 204). Auto-covered by CI shard 6 (code.api.UKOpenBanking package prefix) with no matrix changes needed. Bumps ApiVersionUtilsTest's hardcoded scanned-version count (20 -> 21) per its own documented convention for adding a new version.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan