Add a portable XERBLA handler API#5904
Open
moluopro wants to merge 15 commits into
Open
Conversation
imciner2
reviewed
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #5899 fixed the CTest registration so that
openblas_utest_extran the correct executable, the Windows ARM64 shared-library job exposed failures in thexerbla_*extension tests: some calls from the OpenBLAS DLL reached its normal XERBLA implementation instead of the test executable's override.#5901 works around this Windows DLL symbol-resolution limitation by switching that CI job to a static build. This PR instead adds an explicit XERBLA handler API, giving shared-library users and tests a reliable mechanism that does not depend on link-time symbol interposition.
Changes
openblas_set_xerblafor installing a process-wide handler, returning the previous handler, and restoring the default withNULL.SYMBOLPREFIXandSYMBOLSUFFIXfrom mangling callback types in CMake and Make installs without changing existing Windows export ordinals.