Skip to content

Fix/grid filter bugs#288

Merged
smarcet merged 3 commits into
mainfrom
fix/grid-filter-bugs
Jul 10, 2026
Merged

Fix/grid filter bugs#288
smarcet merged 3 commits into
mainfrom
fix/grid-filter-bugs

Conversation

@santipalenque

@santipalenque santipalenque commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

https://app.clickup.com/t/9014802374/86bah61k7

Summary by CodeRabbit

  • New Features

    • Added a new option to reset all saved grid filters at once.
    • Expanded the grid filter API to include reset-related actions.
  • Bug Fixes

    • Clearing filters now restores the full filter state to its default values across all saved grids.
  • Chores

    • Updated the app version to 5.0.42-beta.0.

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d4bef026-03bc-4a00-8c99-653053a4f1a7

📥 Commits

Reviewing files that changed from the base of the PR and between 928c546 and cf9762b.

📒 Files selected for processing (5)
  • package.json
  • src/components/mui/GridFilter/actions/filter-actions.js
  • src/components/mui/GridFilter/index.js
  • src/components/mui/GridFilter/reducers/all-filters-reducer.js
  • src/components/mui/__tests__/all-filters-reducer.test.js

📝 Walkthrough

Walkthrough

Adds a public resetAllFilters action and RESET_FILTERS constant, updates the reducer to clear all persisted filters, adds reducer coverage, and bumps the package version to 5.0.42-beta.0.

Changes

GridFilter reset behavior

Layer / File(s) Summary
Reset action API
src/components/mui/GridFilter/actions/filter-actions.js, src/components/mui/GridFilter/index.js
Defines RESET_FILTERS and resetAllFilters, then re-exports them through the GridFilter module.
Reducer reset and validation
src/components/mui/GridFilter/reducers/all-filters-reducer.js, src/components/mui/__tests__/all-filters-reducer.test.js, package.json
Resets allFilters to the default state, tests clearing multiple entries, and updates the package version.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: smarcet

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is related to the changeset and accurately signals a GridFilter bug fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/grid-filter-bugs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@smarcet smarcet requested review from Copilot and smarcet July 10, 2026 14:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@smarcet smarcet left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet smarcet merged commit 4e95980 into main Jul 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants