[networking] Improve connection events#75
Open
SpaceWalkerRS wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
LOGIN,PLAY_READY, andDISCONNECTevents currently provide very little context. The client-side events give aMinecraftinstance, and the server-side events give aMinecraftServerinstance and aServerPlayerEntityinstance.This PR replaces those with a single context object through which these instances and other relevant data can be accessed.
The PR also fixes the
DISCONNECTevent not firing if initiated by the remote side. For example, the client-sideDISCONNECTevent would not fire if the player was kicked from the server or had a connection issue. And the server-sideDISCONNECTevent would not fire if the player left the game through the game menu or by closing the game. These issues have been fixed.Here are some example usages of the new API: