Sync pgxntool to 2.1.0#19
Merged
jnasbyupgrade merged 3 commits intoJul 17, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jul 14, 2026
jnasbyupgrade
force-pushed
the
chore/sync-pgxntool
branch
from
July 15, 2026 07:22
a10b67a to
0db30ad
Compare
eb84bc6 Stamp 2.1.0 9fbe6f4 Fix results ordering, control file whitespace, ENABLE_* override, debug levels (#31) 88bb4f2 Add Claude Code GitHub Actions workflows (#41) af5bbbb ci: pass repo owners to run-tests.yml for fork-account matching (#40) c7928af Fix repo-root guard to work inside a git worktree (#39) b062fca ci: point reusable test workflow at @master b6cdbfd Add CI workflows and multi-session PR guard (#33) 1ba0987 Stamp 2.0.3 1931cbe Fix pgxntool-sync remote and make it runnable without make (#37) 8176304 Stamp 2.0.2 3e142ab Fix parse_control_file: remove comments before stripping quotes (#27) cacc301 Stamp 2.0.1 bf1db6b Fix bash 3.2 / Linux compatibility issues (#26) 62d0fcb Fix broken ifeq for --load-language=plpgsql on PG < 13 (#24) 121f0b3 Stamp 2.0.0 ad3ca7e Remove .source support; add test/install, test/build, and verify-results (Postgres-Extensions#18) c010cf8 Fix bash 3.2 compatibility (#23) abeb9d3 Remove .source file support from pg_regress integration (#22) 08c1879 Stamp 1.1.2 6e0dad2 Fix double --dbname bug that defeated unique test database names 639756c Stamp 1.1.1 6ba3176 Fix pg_tle exception handler and empty upgrade files (Postgres-Extensions#15) 3b8cb2a Stamp 1.1.0 550a901 Remove commit.md (maintained in pgxntool-test) d73ca93 Add unique test database names to prevent conflicts (Postgres-Extensions#13) 9b344be Add update-setup-files.sh for 3-way merging after pgxntool-sync (Postgres-Extensions#12) ab7f6e2 Stamp 1.0.0 3a571ba Add pg_tle support and modernize test infrastructure (Postgres-Extensions#11) b96ea6d Add support for Claude code; build and doc improvements (Postgres-Extensions#9) e9c24de Fix pg_regress on versions > 12 (Postgres-Extensions#5) REVERT: bed3604 Fix pg_regress on versions > 12 (Postgres-Extensions#5) (Postgres-Extensions#6) git-subtree-dir: pgxntool git-subtree-split: eb84bc6e87e21f2ced11ff1b8ddb4028b7c67c8f
# Conflicts: # pgxntool/.gitattributes # pgxntool/CLAUDE.md # pgxntool/HISTORY.asc # pgxntool/README.asc # pgxntool/README.html # pgxntool/base.mk # pgxntool/lib.sh # pgxntool/pgtle.sh # pgxntool/setup.sh
Auto-updated .gitignore from pgxntool 2.1.0 and pruned pgxntool's dev-only .github/ and .claude/ (not for embedding projects).
jnasbyupgrade
force-pushed
the
chore/sync-pgxntool
branch
from
July 16, 2026 17:40
0db30ad to
0ec49ae
Compare
jnasbyupgrade
added a commit
that referenced
this pull request
Jul 17, 2026
Both install scripts saved the caller's role in a `CREATE TEMP TABLE original_role ON COMMIT DROP` so they could `SET LOCAL ROLE test_factory__owner` and restore it afterward. That temp table becomes extension-owned, so `ON COMMIT DROP` conflicts with extension ownership (#12: uninstallable; #13: COMMIT fails), and it also collides if the caller already has an `original_role` temp table. Fix: save the caller's role in a transaction-local GUC via `set_config('<ext>.original_role', current_user, true)` and restore with `SET ROLE` at end of script — no extension-owned object, no `ON COMMIT DROP`. Independent of the pgxntool sync (#19); #12/#13 are already closed. --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync the vendored
pgxntool/subtree from 1.0.0 to the 2.1.0 release tag (Postgres-Extensions/pgxntool), via thepgxntool-sync.shflow:git subtree pullpinned to tag2.1.0, thenupdate-setup-files.shreconcile (auto-update.gitignore, prune pgxntool's dev-only.github/and.claude/).The vendored tree is byte-identical to the canonical
2.1.0tag (minus the pruned dev-only dirs). Rebased onto currentmaster(includes #16).make testpasses on PostgreSQL 17 against the existing test layout — the update is backward-compatible.Prerequisite for later switching test_factory to the
test/install/framework (separate PR).