feat: Add data metrics for numeric columns by MoritzPotthoffQC · Pull Request #46 · Quantco/diffly

Moritz Potthoff (MoritzPotthoffQC) · 2026-07-16T08:01:52Z

Motivation

Building on #43, we would like to provide a few more "data" metrics, this time for numeric columns only.

Changes

Add new data metrics, similar to the change metrics

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Co-authored-by: EgeKaraismailogluQC <128645043+EgeKaraismailogluQC@users.noreply.github.com>

…_fraction.py Co-authored-by: EgeKaraismailogluQC <128645043+EgeKaraismailogluQC@users.noreply.github.com>

Co-authored-by: quant-ranger[bot] <132915763+quant-ranger[bot]@users.noreply.github.com> Co-authored-by: Marius Merkle <marius.merkle@quantco.com> Co-authored-by: Marius Merkle <122545105+MariusMerkleQC@users.noreply.github.com>

…d-nullability

codecov · 2026-07-16T08:02:09Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (01cef28) to head (7d2a67f).

Additional details and impacted files

@@            Coverage Diff            @@
##              main       #46   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines         1052      1070   +18     
=========================================
+ Hits          1052      1070   +18

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

Adds additional data metrics (computed per-side, then rendered as old -> new (delta)) for numeric columns, and updates summary rendering + golden fixtures to accommodate the expanded metric set.

Changes:

Added new data-metric functions (mean_data, median_data, min_data, max_data, std_data) and expanded DEFAULT_DATA_METRICS.
Updated summary table rendering to apply consistent overflow handling to metric columns.
Updated tests, docs, and regenerated summary fixtures to reflect the new preset metrics/labels and the updated table layout.

Reviewed changes

Copilot reviewed 86 out of 86 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
diffly/metrics/data.py	Adds numeric “data” metrics and updates the data-metric presets/utilities.
diffly/summary.py	Applies consistent overflow behavior to metric columns in the Columns section.
docs/api/metrics.rst	Updates API docs to list the newly added data metrics and renamed null-fraction metric.
tests/test_metrics.py	Adds unit tests for new data metrics and renames null-fraction test targets.
tests/cli/test_cli.py	Updates CLI metric-selection test to use the new data-metric preset label.
tests/summary/fixtures/metrics_null_fraction/test_metrics_null_fraction.py	Updates fixture generator test to use the expanded data-metric preset set.
tests/summary/fixtures/metrics_presets_many/gen/pretty_True_perfect_True_top_True_slim_True_sample_rows_True_sample_pk_True.txt	Golden fixture updated for new/wrapped metric headers.
tests/summary/fixtures/metrics_presets_many/gen/pretty_True_perfect_True_top_True_slim_True_sample_rows_False_sample_pk_False.txt	Golden fixture updated for new/wrapped metric headers.
tests/summary/fixtures/metrics_presets_many/gen/pretty_True_perfect_True_top_True_slim_False_sample_rows_True_sample_pk_True.txt	Golden fixture updated for new/wrapped metric headers.
tests/summary/fixtures/metrics_presets_many/gen/pretty_True_perfect_True_top_True_slim_False_sample_rows_False_sample_pk_False.txt	Golden fixture updated for new/wrapped metric headers.
tests/summary/fixtures/metrics_presets_many/gen/pretty_True_perfect_False_top_True_slim_True_sample_rows_True_sample_pk_True.txt	Golden fixture updated for new/wrapped metric headers.
tests/summary/fixtures/metrics_presets_many/gen/pretty_True_perfect_False_top_True_slim_True_sample_rows_False_sample_pk_False.txt	Golden fixture updated for new/wrapped metric headers.
tests/summary/fixtures/metrics_presets_many/gen/pretty_True_perfect_False_top_True_slim_False_sample_rows_True_sample_pk_True.txt	Golden fixture updated for new/wrapped metric headers.
tests/summary/fixtures/metrics_presets_many/gen/pretty_True_perfect_False_top_True_slim_False_sample_rows_False_sample_pk_False.txt	Golden fixture updated for new/wrapped metric headers.
tests/summary/fixtures/metrics_presets_many/gen/pretty_False_perfect_True_top_True_slim_True_sample_rows_True_sample_pk_True.txt	Golden fixture updated for new/wrapped metric headers.
tests/summary/fixtures/metrics_presets_many/gen/pretty_False_perfect_True_top_True_slim_True_sample_rows_False_sample_pk_False.txt	Golden fixture updated for new/wrapped metric headers.
tests/summary/fixtures/metrics_presets_many/gen/pretty_False_perfect_True_top_True_slim_False_sample_rows_True_sample_pk_True.txt	Golden fixture updated for new/wrapped metric headers.
tests/summary/fixtures/metrics_presets_many/gen/pretty_False_perfect_True_top_True_slim_False_sample_rows_False_sample_pk_False.txt	Golden fixture updated for new/wrapped metric headers.
tests/summary/fixtures/metrics_presets_many/gen/pretty_False_perfect_False_top_True_slim_True_sample_rows_True_sample_pk_True.txt	Golden fixture updated for new/wrapped metric headers.
tests/summary/fixtures/metrics_presets_many/gen/pretty_False_perfect_False_top_True_slim_True_sample_rows_False_sample_pk_False.txt	Golden fixture updated for new/wrapped metric headers.
tests/summary/fixtures/metrics_presets_many/gen/pretty_False_perfect_False_top_True_slim_False_sample_rows_True_sample_pk_True.txt	Golden fixture updated for new/wrapped metric headers.
tests/summary/fixtures/metrics_presets_many/gen/pretty_False_perfect_False_top_True_slim_False_sample_rows_False_sample_pk_False.txt	Golden fixture updated for new/wrapped metric headers.
tests/summary/fixtures/metrics_null_fraction/gen/pretty_True_perfect_True_top_False_slim_True_sample_rows_True_sample_pk_False.txt	Golden fixture updated for expanded data metrics in the Columns table.
tests/summary/fixtures/metrics_null_fraction/gen/pretty_True_perfect_True_top_False_slim_True_sample_rows_False_sample_pk_False.txt	Golden fixture updated for expanded data metrics in the Columns table.
tests/summary/fixtures/metrics_null_fraction/gen/pretty_True_perfect_True_top_False_slim_False_sample_rows_True_sample_pk_False.txt	Golden fixture updated for expanded data metrics in the Columns table.
tests/summary/fixtures/metrics_null_fraction/gen/pretty_True_perfect_True_top_False_slim_False_sample_rows_False_sample_pk_False.txt	Golden fixture updated for expanded data metrics in the Columns table.
tests/summary/fixtures/metrics_null_fraction/gen/pretty_True_perfect_False_top_False_slim_True_sample_rows_True_sample_pk_False.txt	Golden fixture updated for expanded data metrics in the Columns table.
tests/summary/fixtures/metrics_null_fraction/gen/pretty_True_perfect_False_top_False_slim_True_sample_rows_False_sample_pk_False.txt	Golden fixture updated for expanded data metrics in the Columns table.
tests/summary/fixtures/metrics_null_fraction/gen/pretty_True_perfect_False_top_False_slim_False_sample_rows_True_sample_pk_False.txt	Golden fixture updated for expanded data metrics in the Columns table.
tests/summary/fixtures/metrics_null_fraction/gen/pretty_True_perfect_False_top_False_slim_False_sample_rows_False_sample_pk_False.txt	Golden fixture updated for expanded data metrics in the Columns table.
tests/summary/fixtures/metrics_null_fraction/gen/pretty_False_perfect_True_top_True_slim_True_sample_rows_False_sample_pk_False.txt	Golden fixture updated for expanded data metrics in the Columns table.
tests/summary/fixtures/metrics_null_fraction/gen/pretty_False_perfect_True_top_True_slim_False_sample_rows_False_sample_pk_False.txt	Golden fixture updated for expanded data metrics in the Columns table.
tests/summary/fixtures/metrics_null_fraction/gen/pretty_False_perfect_True_top_False_slim_True_sample_rows_True_sample_pk_False.txt	Golden fixture updated for expanded data metrics in the Columns table.
tests/summary/fixtures/metrics_null_fraction/gen/pretty_False_perfect_True_top_False_slim_True_sample_rows_False_sample_pk_False.txt	Golden fixture updated for expanded data metrics in the Columns table.
tests/summary/fixtures/metrics_null_fraction/gen/pretty_False_perfect_True_top_False_slim_False_sample_rows_True_sample_pk_False.txt	Golden fixture updated for expanded data metrics in the Columns table.
tests/summary/fixtures/metrics_null_fraction/gen/pretty_False_perfect_True_top_False_slim_False_sample_rows_False_sample_pk_False.txt	Golden fixture updated for expanded data metrics in the Columns table.
tests/summary/fixtures/metrics_null_fraction/gen/pretty_False_perfect_False_top_True_slim_True_sample_rows_False_sample_pk_False.txt	Golden fixture updated for expanded data metrics in the Columns table.
tests/summary/fixtures/metrics_null_fraction/gen/pretty_False_perfect_False_top_True_slim_False_sample_rows_False_sample_pk_False.txt	Golden fixture updated for expanded data metrics in the Columns table.
tests/summary/fixtures/metrics_null_fraction/gen/pretty_False_perfect_False_top_False_slim_True_sample_rows_True_sample_pk_False.txt	Golden fixture updated for expanded data metrics in the Columns table.
tests/summary/fixtures/metrics_null_fraction/gen/pretty_False_perfect_False_top_False_slim_True_sample_rows_False_sample_pk_False.txt	Golden fixture updated for expanded data metrics in the Columns table.
tests/summary/fixtures/metrics_null_fraction/gen/pretty_False_perfect_False_top_False_slim_False_sample_rows_True_sample_pk_False.txt	Golden fixture updated for expanded data metrics in the Columns table.
tests/summary/fixtures/metrics_null_fraction/gen/pretty_False_perfect_False_top_False_slim_False_sample_rows_False_sample_pk_False.txt	Golden fixture updated for expanded data metrics in the Columns table.
tests/summary/fixtures/metrics_long_labels/gen/pretty_True_perfect_True_top_True_slim_True_sample_rows_True_sample_pk_True.txt	Golden fixture updated for wrapped headers with long metric labels.
tests/summary/fixtures/metrics_long_labels/gen/pretty_True_perfect_True_top_True_slim_True_sample_rows_False_sample_pk_False.txt	Golden fixture updated for wrapped headers with long metric labels.
tests/summary/fixtures/metrics_long_labels/gen/pretty_True_perfect_True_top_True_slim_False_sample_rows_True_sample_pk_True.txt	Golden fixture updated for wrapped headers with long metric labels.
tests/summary/fixtures/metrics_long_labels/gen/pretty_True_perfect_True_top_True_slim_False_sample_rows_False_sample_pk_False.txt	Golden fixture updated for wrapped headers with long metric labels.
tests/summary/fixtures/metrics_long_labels/gen/pretty_True_perfect_True_top_False_slim_True_sample_rows_True_sample_pk_False.txt	Golden fixture updated for wrapped headers with long metric labels.
tests/summary/fixtures/metrics_long_labels/gen/pretty_True_perfect_True_top_False_slim_True_sample_rows_False_sample_pk_False.txt	Golden fixture updated for wrapped headers with long metric labels.
tests/summary/fixtures/metrics_long_labels/gen/pretty_True_perfect_True_top_False_slim_False_sample_rows_True_sample_pk_False.txt	Golden fixture updated for wrapped headers with long metric labels.
tests/summary/fixtures/metrics_long_labels/gen/pretty_True_perfect_True_top_False_slim_False_sample_rows_False_sample_pk_False.txt	Golden fixture updated for wrapped headers with long metric labels.
tests/summary/fixtures/metrics_long_labels/gen/pretty_True_perfect_False_top_True_slim_True_sample_rows_True_sample_pk_True.txt	Golden fixture updated for wrapped headers with long metric labels.
tests/summary/fixtures/metrics_long_labels/gen/pretty_True_perfect_False_top_True_slim_True_sample_rows_False_sample_pk_False.txt	Golden fixture updated for wrapped headers with long metric labels.
tests/summary/fixtures/metrics_long_labels/gen/pretty_True_perfect_False_top_False_slim_True_sample_rows_False_sample_pk_False.txt	Golden fixture updated for wrapped headers with long metric labels.
tests/summary/fixtures/metrics_long_labels/gen/pretty_True_perfect_False_top_False_slim_False_sample_rows_True_sample_pk_False.txt	Golden fixture updated for wrapped headers with long metric labels.
tests/summary/fixtures/metrics_long_labels/gen/pretty_True_perfect_False_top_False_slim_False_sample_rows_False_sample_pk_False.txt	Golden fixture updated for wrapped headers with long metric labels.
tests/summary/fixtures/metrics_long_labels/gen/pretty_False_perfect_True_top_True_slim_True_sample_rows_True_sample_pk_True.txt	Golden fixture updated for wrapped headers with long metric labels.
tests/summary/fixtures/metrics_long_labels/gen/pretty_False_perfect_True_top_True_slim_True_sample_rows_False_sample_pk_False.txt	Golden fixture updated for wrapped headers with long metric labels.
tests/summary/fixtures/metrics_long_labels/gen/pretty_False_perfect_True_top_True_slim_False_sample_rows_True_sample_pk_True.txt	Golden fixture updated for wrapped headers with long metric labels.
tests/summary/fixtures/metrics_long_labels/gen/pretty_False_perfect_True_top_True_slim_False_sample_rows_False_sample_pk_False.txt	Golden fixture updated for wrapped headers with long metric labels.
tests/summary/fixtures/metrics_long_labels/gen/pretty_False_perfect_True_top_False_slim_True_sample_rows_True_sample_pk_False.txt	Golden fixture updated for wrapped headers with long metric labels.
tests/summary/fixtures/metrics_long_labels/gen/pretty_False_perfect_True_top_False_slim_True_sample_rows_False_sample_pk_False.txt	Golden fixture updated for wrapped headers with long metric labels.
tests/summary/fixtures/metrics_long_labels/gen/pretty_False_perfect_True_top_False_slim_False_sample_rows_True_sample_pk_False.txt	Golden fixture updated for wrapped headers with long metric labels.
tests/summary/fixtures/metrics_long_labels/gen/pretty_False_perfect_True_top_False_slim_False_sample_rows_False_sample_pk_False.txt	Golden fixture updated for wrapped headers with long metric labels.
tests/summary/fixtures/metrics_long_labels/gen/pretty_False_perfect_False_top_True_slim_True_sample_rows_True_sample_pk_True.txt	Golden fixture updated for wrapped headers with long metric labels.
tests/summary/fixtures/metrics_long_labels/gen/pretty_False_perfect_False_top_True_slim_True_sample_rows_False_sample_pk_False.txt	Golden fixture updated for wrapped headers with long metric labels.
tests/summary/fixtures/metrics_long_labels/gen/pretty_False_perfect_False_top_True_slim_False_sample_rows_True_sample_pk_True.txt	Golden fixture updated for wrapped headers with long metric labels.
tests/summary/fixtures/metrics_long_labels/gen/pretty_False_perfect_False_top_True_slim_False_sample_rows_False_sample_pk_False.txt	Golden fixture updated for wrapped headers with long metric labels.
tests/summary/fixtures/metrics_long_labels/gen/pretty_False_perfect_False_top_False_slim_True_sample_rows_True_sample_pk_False.txt	Golden fixture updated for wrapped headers with long metric labels.
tests/summary/fixtures/metrics_long_labels/gen/pretty_False_perfect_False_top_False_slim_True_sample_rows_False_sample_pk_False.txt	Golden fixture updated for wrapped headers with long metric labels.
tests/summary/fixtures/metrics_long_labels/gen/pretty_False_perfect_False_top_False_slim_False_sample_rows_True_sample_pk_False.txt	Golden fixture updated for wrapped headers with long metric labels.
tests/summary/fixtures/metrics_long_labels/gen/pretty_False_perfect_False_top_False_slim_False_sample_rows_False_sample_pk_False.txt	Golden fixture updated for wrapped headers with long metric labels.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Oliver Borchert (borchero) · 2026-07-17T09:59:55Z

Didn't we want to introduce a new section? 😄

I thought we do that later (as long as you do not mix data and change metrics, the current setup is fine IMO). But I can also work on it before we merge this PR

Ah, I meant it's fine within the context of the previous PR, I'd rather change it as we extend metrics 😄

Okay I will add the new section in a separate PR and redraft this one until then

Moritz Potthoff (MoritzPotthoffQC) and others added 23 commits July 10, 2026 15:39

init

e97b755

better output

1e72823

cleanup

1d7bdeb

refactor

a74429f

Potential fix for pull request finding

71338c9

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

fix

cd33f6a

fix

f66bfa0

Potential fix for pull request finding

db3b168

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Merge branch 'main' into generalize-metrics-add-nullability

eb1c427

Update docs/api/metrics.rst

2923f2e

Co-authored-by: EgeKaraismailogluQC <128645043+EgeKaraismailogluQC@users.noreply.github.com>

Update tests/summary/fixtures/metrics_null_fraction/test_metrics_null…

e1ea6bd

…_fraction.py Co-authored-by: EgeKaraismailogluQC <128645043+EgeKaraismailogluQC@users.noreply.github.com>

chore: Update pixi lockfile (#42)

fc0426a

Co-authored-by: quant-ranger[bot] <132915763+quant-ranger[bot]@users.noreply.github.com> Co-authored-by: Marius Merkle <marius.merkle@quantco.com> Co-authored-by: Marius Merkle <122545105+MariusMerkleQC@users.noreply.github.com>

review

f5b9117

fix

e374f0d

fix

627721e

Merge remote-tracking branch 'origin/main' into generalize-metrics-ad…

cf686b4

…d-nullability

fix

529b917

fix

6f5671d

fix docs

bfc8d8c

fix docs

bfc03ad

review

b309e7a

fix CLI

901590c

init

e35a81e

fix

9177c8c

Base automatically changed from generalize-metrics-add-nullability to main July 16, 2026 10:57

github-actions Bot added the enhancement New feature or request label Jul 16, 2026

Moritz Potthoff (MoritzPotthoffQC) added 3 commits July 16, 2026 13:48

Merge remote-tracking branch 'origin/main' into more-data-metrics

b1c4028

improve

c832e95

fix overflow

7d2a67f

Moritz Potthoff (MoritzPotthoffQC) requested a review from Copilot July 16, 2026 11:59

Copilot started reviewing on behalf of Moritz Potthoff (MoritzPotthoffQC) July 16, 2026 12:00 View session

Copilot AI reviewed Jul 16, 2026

View reviewed changes

Comment thread diffly/metrics/data.py

Comment thread diffly/metrics/data.py

Comment thread diffly/metrics/data.py

Comment thread diffly/metrics/data.py

Moritz Potthoff (MoritzPotthoffQC) marked this pull request as ready for review July 16, 2026 13:10

Moritz Potthoff (MoritzPotthoffQC) requested review from EgeKaraismailogluQC, Marius Merkle (MariusMerkleQC) and Oliver Borchert (borchero) as code owners July 16, 2026 13:10

Moritz Potthoff (MoritzPotthoffQC) self-assigned this Jul 16, 2026

Oliver Borchert (borchero) reviewed Jul 17, 2026

View reviewed changes

Moritz Potthoff (MoritzPotthoffQC) marked this pull request as draft July 17, 2026 11:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Add data metrics for numeric columns#46

feat: Add data metrics for numeric columns#46
Moritz Potthoff (MoritzPotthoffQC) wants to merge 27 commits into
mainfrom
more-data-metrics

Moritz Potthoff (MoritzPotthoffQC) commented Jul 16, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Jul 16, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Oliver Borchert (borchero) Jul 17, 2026

Uh oh!

Moritz Potthoff (MoritzPotthoffQC) Jul 17, 2026

Uh oh!

Oliver Borchert (borchero) Jul 17, 2026

Uh oh!

Moritz Potthoff (MoritzPotthoffQC) Jul 17, 2026

Uh oh!

Moritz Potthoff (MoritzPotthoffQC) Jul 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Moritz Potthoff (MoritzPotthoffQC) commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Changes

Uh oh!

codecov Bot commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Oliver Borchert (borchero) Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

Moritz Potthoff (MoritzPotthoffQC) Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

Oliver Borchert (borchero) Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

Moritz Potthoff (MoritzPotthoffQC) Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

Moritz Potthoff (MoritzPotthoffQC) Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Moritz Potthoff (MoritzPotthoffQC) commented Jul 16, 2026 •

edited

Loading

codecov Bot commented Jul 16, 2026 •

edited

Loading