fix(gate): require whitespace after select in the raw-query shape

[veksen]

Goal

Stop the untested-data-access CI gate from reporting false positives to users. Tracked in Query-Doctor/Site#3615 (dogfooding); the triggering PR was Site#3614, a TanStack Router route-tree regeneration.

What

Before: a PR that regenerated apps/app/src/routeTree.gen.ts was flagged as changing an untested query, listing that file under "changed data-access files with no related data-layer test". The file has no data access — it is route wiring.

After: the regeneration is not flagged. A route path no longer reads as a SQL query.

How

The gate's raw-query heuristic included /\bselect\b[\s\S]{0,300}?\bfrom\b/i. \bselect\b matched the /membership/select-plan route path because the hyphen is a word boundary, and an import from two lines down completed the shape — so a route path parsed as SELECT … FROM.

The one-line fix requires whitespace after select, as real SELECT … FROM has:

- /\bselect\b[\s\S]{0,300}?\bfrom\b/i
+ /\bselect\s[\s\S]{0,300}?\bfrom\b/i

select-plan (hyphen), select.foo (dot), select/x (slash) no longer match. Camel/underscore identifiers (selectPlan, select_plan) never matched \bselect\b, so they are unaffected. Read src/gate/test-presence.ts first (the pattern), then the tests.

Tests

src/gate/test-presence.test.ts:

• the select-plan route path is not classified as data-access (the reported case);
• a raw SELECT id, name FROM users still is — recall guard, so the tightening doesn't blind the raw-SQL shape;
• the end-to-end Site#3614 regeneration produces no verdict.

Full suite green (310 tests), typecheck clean.

Refs Query-Doctor/Site#3615

[github-actions]

Query Doctor Analysis

3 queries analyzed

0 regressed · 0 improved · 0 new · 0 removed

2 pre-existing issues

• SELECT "guests"."id", "guests"."session_id", "guests"."username", "guests"."avatar_path", "guests"."color", "guests"."side", "guests"."audio_recording_path", "guests"."audio_recording_public", "gue...
  index assets(event_id, inserted_at desc)
  cost 31,003,449 → 1,498 (100% reduction)
• SELECT * FROM guest_ip_addresses WHERE ip_address = '127.0.0.1';
  index guest_ip_addresses(ip_address)
  cost 154,402 → 8 (100% reduction)

_{Using assumed statistics (10000000 rows/table). For better results, sync production stats.}

_{More detail → get_ci_run({ runId: "019f86ed-7a5a-7a1a-82f1-23837447076e" }) · view run · docs}