Updates to Enable ICARUS WireMod Closure#911
Open
gputnam wants to merge 10 commits into
Open
Conversation
…age of SignalROIF, rounding of floats, fixed scaling factors to 1 at al. )
Moved the TGraph2D interpolation to an option (UseGraph2DInterpolation), default is true. Renamed the fcls with _pops_ to _develop_ (bad practice on my local branch that got picked up) Added a fcl for null-wiremod modification. Added a fcl for the full diagnostic available in ntuples, including the modified ROIs.
…n channelROI to recob::Wire. There is a different approach which should be used in the future and can be tested with UseChannelROIMode: true, which Harry introduced to skip these conversions. UseChannelROIMode is ideal, but it was tested with a small sample, need higher stats check to verify that closure is achieved also in this way.
francescopoppi
approved these changes
Jul 10, 2026
Contributor
There was a problem hiding this comment.
I have stared at this code for weeks, I played with it extensively and I think we added all possible existing diagnostic tools. In this review I went through everything again and I do not see residual issues. One thing I tried to make sure is that all the different fcls are pointing to the correct configuration.
I will leave 3 open taks with this PR which are implicitly assigned to myself:
- huge cleanup of the fcls, right now 80% of the newly added fcls were used to debug wireMod. I think they will be very useful in the near future, hence they do not need to be removed, but in the future a cleanup is needed, e.g. remove the unused ones, remove duplicated config declarations.
- the YZ corrections have not been tested, code is there, ready to apply them, but it needs to be double checked once we have the respective ratios.
- UseChannelROIMode is to be favored wrt to what it is used in the standard fcls. Results should be identical, but it is favored as it removes some iffy conversions along the procedure. FCLs will be updated after extensive closure tests will confirm the similar results.
A note for the release manager and the readers: all these fixes are related to WireMod and WireMod only. They will not impact other processing stages, unless they actively call for wire modification.
Approved by me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.