Updates to Enable ICARUS WireMod Closure#660
Conversation
…age of SignalROIF, rounding of floats, fixed scaling factors to 1 at al. )
…ff when using additive modification. Second I modified the interpolation that was stopping at bin center for bins at the borders, in this case we clamp the interpolation to the outer bin edge. Third I introduced a flag which allows WireMod to either use interpolation or pick up the scaling factor from the closest bin center.
| } else if (isnan(q_mod)) { | ||
| if (isnan(q_mod)) { | ||
| if (verbose) | ||
| std::cout << "WARNING: obtained q_mod = NaN... setting scale to 0" << std::endl; |
There was a problem hiding this comment.
do we want a guard that sets scaling factors to 1.0 instead of 0? Probably we do
There was a problem hiding this comment.
" I think there is the need to add a guard to nan scaling factors with fallback scaling factors to 1. The finger points to Francesco to do it. Ok, I am on it, early US morning I will fix it. "
This was my old comment, but after going through the rabbit hole, q_nan is an implicit fallback to scaling factors of one, simply it does not scale the rois.
Besides this, I really would like to wait Thomas or SBND review to make sure we are not butchering their WireMod implementation. We should not, as the biggest changes come from additional parameters which are defaulted to current SBNcode implementation and are updated only through icarus fcls.
2 participants
No description provided.