Ignore all-blank columns when loading projects (#1985)#2586
Open
akenmorris wants to merge 4 commits into
Open
Conversation
Copy/pasted spreadsheets often leave an orphaned header (e.g. "world_particles_femur") whose cells are all blank. Previously this created a phantom domain and blank particle-file reads, making the project fail to load. ProjectReader::load_subjects now drops any column that is blank for every subject before parsing, so orphaned all-blank headers are ignored. Applies to both the Excel and JSON readers via the shared base class. Adds ProjectTests.ignore_blank_columns_test with a fixture exercising a phantom all-blank domain and an all-blank extra column.
…-blank-columns # Conflicts: # Testing/ProjectTests/ProjectTests.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy/pasted spreadsheets often leave an orphaned header (e.g. "world_particles_femur") whose cells are all blank. Previously this created a phantom domain and blank particle-file reads, making the project fail to load.
ProjectReader::load_subjects now drops any column that is blank for every subject before parsing, so orphaned all-blank headers are ignored. Applies to both the Excel and JSON readers via the shared base class.
Adds ProjectTests.ignore_blank_columns_test with a fixture exercising a phantom all-blank domain and an all-blank extra column.