Skip to content

Use relative GraphiQL asset paths#8010

Open
alfonso-noriega wants to merge 1 commit into
mainfrom
07-06-graphiql-relative-assets
Open

Use relative GraphiQL asset paths#8010
alfonso-noriega wants to merge 1 commit into
mainfrom
07-06-graphiql-relative-assets

Conversation

@alfonso-noriega

@alfonso-noriega alfonso-noriega commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The GraphiQL server resolves package-local assets through @shopify/cli-kit/... package imports. Newer Nx lint rules flag that as a same-project boundary violation and have blocked dependency-update PRs.

WHAT is this pull request doing?

  • Reads the GraphiQL favicon and stylesheet via paths relative to server.ts instead of resolving them through the package import alias.
  • Updates the bundling rewrite plugin to handle those relative asset URLs and keep bundled CLI asset resolution working.

How to test your changes?

  • pnpm nx run cli-kit:lint
  • pnpm vitest run packages/cli-kit/src/public/node/graphiql/server.test.ts
  • pnpm nx run cli-kit:type-check
  • pnpm bundle-for-release

Post-release steps

None.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • This change is not user-facing and does not need a changeset.

@alfonso-noriega alfonso-noriega requested a review from a team as a code owner July 6, 2026 17:26

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 6, 2026
Assisted-By: devx/56dcddb4-0bb1-4e96-b794-1bb2fda2cba1
@alfonso-noriega alfonso-noriega force-pushed the 07-06-graphiql-relative-assets branch from e346a0b to b2f834b Compare July 6, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant