Signals stacked view + inline SVG file-type icons#27
Merged
Conversation
Signals panel: - Add Overlay | Stacked layout toggle to the Signals toolbar. - Stacked mode renders each selected signal in its own horizontal band with an independent y-scale, name + min/max axis labels, and dots at each signal's global extrema. All bands share one bottom time axis so they line up vertically. - Add a synced crosshair (both modes): a dashed vertical time line spanning the plot with a colored value dot per signal at the hovered sample. Hover redraws are rAF-coalesced for smoothness. - Normalize is disabled in stacked mode (each band already auto-scales). - Refactor drawSignalsChart into drawSignalsOverlay / drawSignalsStacked / drawSignalsCrosshair; x-geometry stays shared so existing click-to-line and nearest-sample hit-testing are unchanged. File-type icons: - Replace the per-OS emoji glyphs in fileTypeIcon() with inline Lucide-style SVGs (FILE_ICON_PATHS + svgFileIcon helper), stroked with currentColor. - Per-type CSS tint classes (MF4 uses the Signals accent color); icons are themeable, crisp at any DPI, and uniform in stroke weight. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signals panel — Stacked (time-synced) view
drawSignalsChartrefactored intodrawSignalsOverlay/drawSignalsStacked/drawSignalsCrosshair; x-geometry stays shared so click-to-line and nearest-sample hit-testing are unchanged.File-type icons — inline SVG
fileTypeIcon()emoji glyphs replaced with inline Lucide-style SVGs (FILE_ICON_PATHS+svgFileIconhelper), stroked withcurrentColor.Build green (
npm run build)..mcp.jsonintentionally not included.🤖 Generated with Claude Code