PR_26179_CHARLIE_024-sprites-canvas-grid#260
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 07f81affb2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .sprite-canvas-grid { | ||
| --sprite-grid-size: 16; | ||
| display: grid; | ||
| grid-template-columns: repeat(var(--sprite-grid-size), minmax(0, 1fr)); |
There was a problem hiding this comment.
Load the sprite grid styles from the active bundle
The sprite page links only assets/theme-v2/css/theme.css, and that file does not import gamefoundrystudio.css (I also checked runtime references with rg "gamefoundrystudio\\.css"). Because these new .sprite-canvas-* rules live in an unloaded stylesheet, /toolbox/sprites/index.html never receives display: grid, column sizing, aspect ratio, or cell borders, so the generated 16x16/32x32 cells render as unstyled disabled buttons instead of the visible pixel canvas this PR adds. Move or import the rules into the active Theme V2 bundle.
Useful? React with 👍 / 👎.
Summary
Validation
node --check assets/toolbox/sprites/js/index.jsPASSnode --check dev/tests/playwright/tools/SpritesToolShell.spec.mjsPASSgit diff --check ...PASSnpx playwright test dev/tests/playwright/tools/SpritesToolShell.spec.mjs --workers=1 --reporter=list --output=<temp>PASS, 1 test passedArtifact
dev/workspace/zip/PR_26179_CHARLIE_024-sprites-canvas-grid_delta.zip