Skip to content

PR_26179_CHARLIE_024-sprites-canvas-grid#260

Merged
ToolboxAid merged 1 commit into
mainfrom
PR_26179_CHARLIE_024-sprites-canvas-grid
Jun 28, 2026
Merged

PR_26179_CHARLIE_024-sprites-canvas-grid#260
ToolboxAid merged 1 commit into
mainfrom
PR_26179_CHARLIE_024-sprites-canvas-grid

Conversation

@ToolboxAid

Copy link
Copy Markdown
Owner

Summary

Validation

  • node --check assets/toolbox/sprites/js/index.js PASS
  • node --check dev/tests/playwright/tools/SpritesToolShell.spec.mjs PASS
  • git diff --check ... PASS
  • guard scan PASS
  • npx playwright test dev/tests/playwright/tools/SpritesToolShell.spec.mjs --workers=1 --reporter=list --output=<temp> PASS, 1 test passed

Artifact

  • dev/workspace/zip/PR_26179_CHARLIE_024-sprites-canvas-grid_delta.zip

@ToolboxAid ToolboxAid marked this pull request as ready for review June 28, 2026 20:12
@ToolboxAid ToolboxAid changed the base branch from PR_26179_CHARLIE_023-sprites-toolbar-placeholders to main June 28, 2026 20:12
@ToolboxAid ToolboxAid merged commit a03ec39 into main Jun 28, 2026
1 check passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 07f81affb2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +1165 to +1168
.sprite-canvas-grid {
--sprite-grid-size: 16;
display: grid;
grid-template-columns: repeat(var(--sprite-grid-size), minmax(0, 1fr));

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Load the sprite grid styles from the active bundle

The sprite page links only assets/theme-v2/css/theme.css, and that file does not import gamefoundrystudio.css (I also checked runtime references with rg "gamefoundrystudio\\.css"). Because these new .sprite-canvas-* rules live in an unloaded stylesheet, /toolbox/sprites/index.html never receives display: grid, column sizing, aspect ratio, or cell borders, so the generated 16x16/32x32 cells render as unstyled disabled buttons instead of the visible pixel canvas this PR adds. Move or import the rules into the active Theme V2 bundle.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant