-
Notifications
You must be signed in to change notification settings - Fork 0
PR_26179_CHARLIE_026-sprites-palette-panel #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1199,6 +1199,46 @@ body.tool-focus-mode .tool-column:last-of-type { | |
| background: var(--text) | ||
| } | ||
|
|
||
| .sprite-canvas-cell--ink, | ||
| .sprite-color-chip--ink { | ||
| background: var(--text) | ||
| } | ||
|
|
||
| .sprite-canvas-cell--orange, | ||
| .sprite-color-chip--orange { | ||
| background: var(--molten-orange) | ||
|
Comment on lines
+1207
to
+1209
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When these palette styles are loaded, painted cells still keep the old ink background because each cell gets both Useful? React with 👍 / 👎. |
||
| } | ||
|
|
||
| .sprite-canvas-cell--gold, | ||
| .sprite-color-chip--gold { | ||
| background: var(--forge-gold) | ||
| } | ||
|
|
||
| .sprite-canvas-cell--green, | ||
| .sprite-color-chip--green { | ||
| background: var(--green) | ||
| } | ||
|
|
||
| .sprite-canvas-cell--blue, | ||
| .sprite-color-chip--blue { | ||
| background: var(--electric-blue) | ||
| } | ||
|
|
||
| .sprite-palette-panel { | ||
| display: flex; | ||
| flex-wrap: wrap; | ||
| gap: 8px | ||
| } | ||
|
|
||
| .sprite-color-chip { | ||
| display: inline-block; | ||
| width: 14px; | ||
| height: 14px; | ||
| border: 1px solid var(--swatch-border); | ||
| border-radius: 50%; | ||
| box-shadow: 0 1px 4px var(--swatch-shadow-color) | ||
| } | ||
|
|
||
| @media(max-width:980px) { | ||
|
|
||
| .grid.cols-4, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| # PR_26179_CHARLIE_026-sprites-palette-panel | ||
|
|
||
| Team: CHARLIE | ||
| Workflow: stacked feature workflow | ||
| Base branch: PR_26179_CHARLIE_025-sprites-basic-drawing | ||
| Canonical ZIP path: dev/workspace/zip/PR_26179_CHARLIE_026-sprites-palette-panel_delta.zip | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The repo packaging instructions require every BUILD artifact at Useful? React with 👍 / 👎. |
||
|
|
||
| ## Summary | ||
|
|
||
| Added an editor-only palette panel with active color selection. Selected editor colors apply to Pencil and Fill drawing in unsaved page-session state. The page still states that Palette/Colors remains the reusable color source for future saved sprite records. | ||
|
|
||
| ## Branch Validation | ||
|
|
||
| PASS | ||
|
|
||
| - Current branch: PR_26179_CHARLIE_026-sprites-palette-panel | ||
| - Based on: PR_26179_CHARLIE_025-sprites-basic-drawing | ||
| - No start_of_day files changed | ||
| - No DB/API/schema files changed | ||
| - No stale PR #219-#228 code copied | ||
|
|
||
| ## Requirement Checklist | ||
|
|
||
| | Requirement | Status | Notes | | ||
| | --- | --- | --- | | ||
| | Add active color selection | PASS | Palette buttons update active editor color. | | ||
| | Add basic preset palette | PASS | Ink, Orange, Gold, Green, and Blue editor presets are visible. | | ||
| | Connect selected color to drawing tools | PASS | Pencil and Fill apply selected color classes. | | ||
| | Creator-facing language | PASS | Copy describes editor draft colors and future Palette/Colors source. | | ||
| | No DB/API | PASS | No API/database changes. | | ||
| | No browser-owned authoritative product data | PASS | No product save or browser storage. | | ||
|
|
||
| ## Validation Lane Report | ||
|
|
||
| Commands: | ||
|
|
||
| ```text | ||
| node --check assets/toolbox/sprites/js/index.js | ||
| node --check dev/tests/playwright/tools/SpritesToolShell.spec.mjs | ||
| git diff --check -- toolbox/sprites/index.html assets/toolbox/sprites/js/index.js assets/theme-v2/css/gamefoundrystudio.css dev/tests/playwright/tools/SpritesToolShell.spec.mjs | ||
| rg --pcre2 -n -i "localStorage|sessionStorage|indexedDB|<style|style=|<script(?![^>]+src=)|on(click|change|submit|input|load|error)=|imageDataUrl|local-mem|fake-login|MEM DB" toolbox/sprites/index.html assets/toolbox/sprites/js/index.js dev/tests/playwright/tools/SpritesToolShell.spec.mjs | ||
| npx playwright test dev/tests/playwright/tools/SpritesToolShell.spec.mjs --workers=1 --reporter=list --output=<temp> | ||
| ``` | ||
|
|
||
| Results: | ||
|
|
||
| - Node syntax checks: PASS | ||
| - `git diff --check`: PASS | ||
| - Guard scan: PASS, no matches | ||
| - Targeted Playwright: PASS, 1 test passed | ||
|
|
||
| ## Manual Validation Notes | ||
|
|
||
| 1. Open `/toolbox/sprites/index.html` from the stacked branch. | ||
| 2. Select Gold, use Pencil, and confirm the painted pixel uses Gold. | ||
| 3. Select Blue, use Fill, and confirm the grid uses Blue. | ||
| 4. Confirm the page states Palette/Colors remains the reusable color source for future saved records. | ||
|
|
||
| ## ZIP Path | ||
|
|
||
| `dev/workspace/zip/PR_26179_CHARLIE_026-sprites-palette-panel_delta.zip` | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sprites page only links
assets/theme-v2/css/theme.css, and that bundle does not importgamefoundrystudio.css, so these new palette/cell color rules are never loaded at runtime. In this context, selecting Gold/Blue toggles classes in JS, but the chips and painted pixels get no palette-specific styling, leaving the new color-selection feature visually ineffective.Useful? React with 👍 / 👎.