Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev/build/ProjectInstructions/PROJECT_INSTRUCTIONS.md
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ Rules:

## Current Version/Date

- Project Instructions Version: 2026.06.28.016
- Project Instructions Version: 2026.06.28.017
- Date: 2026-06-28
- Owner: OWNER

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Project Instructions Version

Current Project Instructions Version: 2026.06.28.016
Current Project Instructions Version: 2026.06.28.017

Last Updated: 2026-06-28

Expand All @@ -24,6 +24,7 @@ Last Updated: 2026-06-28
- Moved the tracked browser-served favicon under `www/`, added remaining root/src audit governance, and documented root `.env` placement policy.
- Added root leftover audit and `src/` transition plan for the final repository layout cleanup stage.
- Removed safe empty local root directory shells and documented blocked local-only `assets/` cleanup.
- Removed the local demo `.gfsp` artifact and recorded a file-by-file `src/` destination audit for future scoped migrations.
- Codex must read this version file and the latest repository copy of `PROJECT_INSTRUCTIONS.md` before performing work.
- Codex must discard previously remembered Project Instructions and treat the repository copy as authoritative.
- Codex must validate canonical report and ZIP paths, branching model, and legacy path avoidance before work proceeds.
12 changes: 6 additions & 6 deletions dev/build/ProjectInstructions/PROJECT_STATE.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Project State

```yaml
project_state_version: "2026.06.28.016"
project_state_version: "2026.06.28.017"
last_updated: "2026-06-28"
current_main_commit: "40de767476d70cadfd1292c916844c2f31b6f185"
repository_status:
Expand All @@ -10,18 +10,18 @@ repository_status:
runtime_database: "Postgres"
creator_metadata: "API to Postgres"
creator_assets: "API to R2"
project_instructions_version: "2026.06.28.016"
repository_structure_version: "2026.06.28.016"
canonical_layout_version: "2026.06.28.016"
project_instructions_version: "2026.06.28.017"
repository_structure_version: "2026.06.28.017"
canonical_layout_version: "2026.06.28.017"
active_teams:
- "Owner"
- "Alfa"
- "Bravo"
- "Charlie"
- "Delta"
- "Golf"
latest_owner_pr: "PR_26180_OWNER_016-remove-empty-root-shells"
latest_structure_pr: "PR_26180_OWNER_016-remove-empty-root-shells"
latest_owner_pr: "PR_26180_OWNER_017-src-dissection-and-demo-cleanup"
latest_structure_pr: "PR_26180_OWNER_017-src-dissection-and-demo-cleanup"
valid_top_level_folders:
- "api/"
- "deploy/"
Expand Down
4 changes: 2 additions & 2 deletions dev/build/ProjectInstructions/backlog/BACKLOG_MASTER.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ The backlog is the authoritative source for determining the next logical PRs.
- Team: Owner
- Product Area: Repository Architecture Simplification
- Status: Active
- Percent Complete: 98%
- Active PR: PR_26180_OWNER_016-remove-empty-root-shells
- Percent Complete: 99%
- Active PR: PR_26180_OWNER_017-src-dissection-and-demo-cleanup
- Next Milestone: Final layout validation and completion report
- Source / Reference: `dev/build/ProjectInstructions/repository/repository_layout_architecture_plan.md`; `dev/build/ProjectInstructions/repository/www_migration_map.md`

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ No browser, API, server, test, script, or runtime files move in the scaffold or

`PR_26180_OWNER_016-remove-empty-root-shells` removes safe empty local root directory shells left behind after the migration and documents the blocked local-only `assets/` shell that contains ignored user data.

`PR_26180_OWNER_017-src-dissection-and-demo-cleanup` removes the local ignored demo `.gfsp` artifact, removes the now-empty `assets/` shell, and records a file-by-file `src/` destination audit without moving source files.

## Proposed Future Layout

```text
Expand Down Expand Up @@ -189,7 +191,13 @@ Rules:
- Do not delete ignored local-only data.
- Document any folder that cannot be removed.

13. `PR_26180_OWNER_017-final-layout-validation`
13. `PR_26180_OWNER_017-src-dissection-and-demo-cleanup`
- Delete the local ignored demo `.gfsp` artifact and remove `assets/` if empty.
- Audit every tracked `src/` file and assign a proposed destination.
- Do not bulk-move `src/`.
- Preserve runtime behavior.

14. `PR_26180_OWNER_018-final-layout-validation`
- Validate final repository layout.
- Confirm `www/` owns the browser-served app, `api/` owns the server app, and `dev/` owns the developer workspace.
- Confirm runtime does not depend on `dev/`, browser code does not import `api/`, and legacy references are removed or documented.
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# PR_26180_OWNER_017 Branch Validation

| Check | Result | Evidence |
|---|---:|---|
| Current branch | PASS | `PR_26180_OWNER_017-src-dissection-and-demo-cleanup` |
| Expected stacked base | PASS | Created from `PR_26180_OWNER_016-remove-empty-root-shells` |
| Base branch for PR | PASS | `PR_26180_OWNER_016-remove-empty-root-shells` |
| Project Instructions loaded | PASS | Repository Project Instructions version `2026.06.28.017` |
| Branching policy loaded | PASS | `PROJECT_BRANCHING_POLICY.md` version `2026.06.28.002` |
| Scope | PASS | Local demo artifact cleanup, `src/` file audit, governance reports only |
| Runtime/API/database implementation changes | PASS | None |
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# PR_26180_OWNER_017 Manual Validation Notes

- Deleted the ignored local demo artifact `assets/DemoGame-26168-001.gfsp`.
- Removed `assets/` after it became empty.
- Confirmed `games/`, `learn/`, `toolbox/`, `tmp/`, and `test-results/` remain absent.
- Confirmed no tracked legacy root files remain in the target set.
- Confirmed all 596 tracked `src/` files are audited.
- No `src/` files moved in this PR.
- Runtime behavior is preserved.
- ZIP output remains under `dev/workspace/zips/`.
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
# PR_26180_OWNER_017 src Dissection and Demo Cleanup Report

## Executive Summary

PR_26180_OWNER_017 removes the local ignored demo artifact `assets/DemoGame-26168-001.gfsp`, removes the now-empty `assets/` shell, and audits every tracked file under `src/`.

No tracked `src/` files are moved in this PR. The file-by-file audit assigns proposed destinations, but most files require scoped reference migrations to preserve runtime behavior.

## Demo Artifact Cleanup

- Deleted local ignored artifact: `assets/DemoGame-26168-001.gfsp`.
- Removed `assets/` after the artifact deletion left the folder empty.
- No tracked files were deleted.
- No active `assets/DemoGame-26168-001.gfsp` path references remain outside reports/workspace.

Filename-only `DemoGame-26168-001.gfsp` references remain in Playwright tests as generated-download assertions. Those are not references to the deleted root file path.

## src Audit Summary

Tracked `src/` files audited: 596.

The detailed file-by-file audit lives at:

`dev/reports/PR_26180_OWNER_017-src-dissection-and-demo-cleanup_src-file-destination-audit.md`

## src Move Decision

No `src/` files moved.

Reason:

- `src/` content is actively referenced by `www/`, `api/`, `dev/tests/`, and `dev/tools/`.
- Moving `src/` files requires scoped import/reference updates.
- The PR request requires preserving runtime behavior.
- Uncertain or mixed-ownership files must be documented before movement.

## Proposed Follow-Up PRs

1. Browser API client migration: move `src/api/` browser clients to a browser-owned location.
2. Engine runtime migration: move `src/engine/` to the final browser/runtime source layer.
3. Shared contract/schema migration: split `src/shared/contracts/` and `src/shared/schemas/` into the API contract surface.
4. Shared utility migration: split `src/shared/` browser/runtime utilities by actual import ownership.
5. Legacy Admin Notes retirement: migrate or retire `src/dev-runtime/admin/`.

## Runtime/Product Impact

No runtime behavior changed. No product code changed. No API/database behavior changed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# PR_26180_OWNER_017 Requirement Checklist

| Requirement | Result | Notes |
|---|---:|---|
| Base on `PR_26180_OWNER_016-remove-empty-root-shells` | PASS | Branch created from PR016. |
| Delete `assets/DemoGame-26168-001.gfsp` | PASS | Local ignored file deleted. |
| Remove `assets/` if empty after deletion | PASS | `assets/` removed after the demo file deletion. |
| Audit every tracked file under `src/` | PASS | 596 tracked `src/` files audited in the detailed audit report. |
| Decide destination for each `src/` file | PASS | Each audited file has proposed destination: `www/`, `api/`, `dev/`, or `archive/delete`. |
| Do not bulk-move `src/` blindly | PASS | No `src/` files moved. |
| Move only files with clear ownership | PASS | No source movement attempted because scoped reference updates are required. |
| If uncertain, document and hard stop before moving | PASS | Uncertain/mixed ownership documented; movement deferred. |
| Preserve runtime behavior | PASS | No runtime/product code moved or changed. |
| `git diff --check` | PASS | Whitespace validation passed. |
| `npm run validate:canonical-structure` | PASS | Canonical guardrail passed. |
| Targeted path/reference scan | PASS | No active `assets/DemoGame...` path references remain. |
| Targeted bootstrap check if paths move | PASS | Bootstrap check passed; no tracked startup paths moved. |
Loading
Loading