-
Notifications
You must be signed in to change notification settings - Fork 0
PR_26180_OWNER_019a-contracts-schemas-obsolescence-audit #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ToolboxAid
wants to merge
1
commit into
PR_26180_OWNER_018-move-src-browser-to-www
Choose a base branch
from
PR_26180_OWNER_019a-contracts-schemas-obsolescence-audit
base: PR_26180_OWNER_018-move-src-browser-to-www
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
90 changes: 90 additions & 0 deletions
90
dev/reports/PR_26180_OWNER_019a-contracts-schemas-obsolescence-audit_audit.csv
Large diffs are not rendered by default.
Oops, something went wrong.
10 changes: 10 additions & 0 deletions
10
...s/PR_26180_OWNER_019a-contracts-schemas-obsolescence-audit_branch-validation.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| # PR_26180_OWNER_019a-contracts-schemas-obsolescence-audit Branch Validation | ||
|
|
||
| | Check | Status | Evidence | | ||
| | --- | --- | --- | | ||
| | Current branch | PASS | `PR_26180_OWNER_019a-contracts-schemas-obsolescence-audit` | | ||
| | Expected stacked base | PASS | Created from `PR_26180_OWNER_018-move-src-browser-to-www`. | | ||
| | Worktree start | PASS | Clean before report generation after preserving prior PR019 hard-stop artifacts in a stash. | | ||
| | Branch model | PASS | Owner stacked governance/report PR from previous dependency branch. | | ||
| | Protected dev workspace | PASS | No protected `dev/workspace/**` files were moved or modified by this audit. | | ||
| | Source movement | PASS | No files moved or deleted. | |
7 changes: 7 additions & 0 deletions
7
...6180_OWNER_019a-contracts-schemas-obsolescence-audit_manual-validation-notes.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # PR_26180_OWNER_019a-contracts-schemas-obsolescence-audit Manual Validation Notes | ||
|
|
||
| - Reviewed active reference surfaces requested by Owner: `www/`, `api/`, `dev/tests/`, `dev/scripts/`, and `package.json` scripts. | ||
| - Treated `www/src/shared/toolbox/schemaOnlyToolPresetValidation.js` as a dynamic browser/runtime reference for all tool schema JSON files because it builds `/src/shared/schemas/tools/<tool>.schema.json` at runtime. | ||
| - No source files were moved, deleted, or rewritten. | ||
| - No protected developer workspace files were moved. | ||
| - Recommended next action is to split/move browser-consumed contracts and schemas to `www/src/shared/...` before retrying API-only migration. |
1,113 changes: 1,113 additions & 0 deletions
1,113
dev/reports/PR_26180_OWNER_019a-contracts-schemas-obsolescence-audit_report.md
Large diffs are not rendered by default.
Oops, something went wrong.
21 changes: 21 additions & 0 deletions
21
..._26180_OWNER_019a-contracts-schemas-obsolescence-audit_requirement-checklist.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # PR_26180_OWNER_019a-contracts-schemas-obsolescence-audit Requirement Checklist | ||
|
|
||
| | Requirement | Status | Evidence | | ||
| | --- | --- | --- | | ||
| | Base is PR018 | PASS | Branch created from `PR_26180_OWNER_018-move-src-browser-to-www`. | | ||
| | List every file under src/shared/contracts and src/shared/schemas | PASS | Detailed report and CSV list 89 tracked files. | | ||
| | Identify references from www | PASS | Exact and dynamic browser schema references captured. | | ||
| | Identify references from api | PASS | No direct active `api/` references found from requested surfaces. | | ||
| | Identify references from dev/tests | PASS | Test references captured per file. | | ||
| | Identify references from dev/scripts | PASS | Script references captured per file, including dynamic schema validation path. | | ||
| | Identify package script references | PASS | `package.json` scanned; no package refs found. | | ||
| | Classify every file | PASS | Classification totals: Active test/validation dependency: 64; Active browser/runtime dependency: 23; Unknown / needs Owner decision: 2. | | ||
| | Determine DB/API supersession | PASS | Per-file supersession recommendation documented. | | ||
| | Recommend exact action per file | PASS | Per-file action documented as move to www, move to dev, or keep temporarily. | | ||
| | Do not delete active runtime/test references | PASS | No files deleted. | | ||
| | Do not move browser-consumed files into api | PASS | No files moved; report recommends browser-consumed files move to `www/`. | | ||
| | Do not leave authoritative product data in browser-owned files | PASS | Audit recommends preserving boundary and does not add product data. | | ||
| | Preserve protected dev workspace | PASS | No protected workspace files moved. | | ||
| | git diff --check | PASS | Passed. | | ||
| | npm run validate:canonical-structure | PASS | Passed with 0 blocking violations. | | ||
| | Required reports and ZIP | PASS | Reports generated under `dev/reports/`; ZIP generated under `dev/workspace/zips/`. | | ||
11 changes: 11 additions & 0 deletions
11
...s/PR_26180_OWNER_019a-contracts-schemas-obsolescence-audit_validation-report.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # PR_26180_OWNER_019a-contracts-schemas-obsolescence-audit Validation Report | ||
|
|
||
| | Validation | Result | Notes | | ||
| | --- | --- | --- | | ||
| | Startup validation | PASS | Loaded Project Instructions v2026.06.28.018 from repository; cached memory discarded. | | ||
| | Branch/base validation | PASS | `PR_26180_OWNER_019a-contracts-schemas-obsolescence-audit` from `PR_26180_OWNER_018-move-src-browser-to-www`. | | ||
| | Audit generation | PASS | 89 tracked contracts/schema files audited. | | ||
| | Protected workspace check | PASS | No protected `dev/workspace/generated/**`, `dev/workspace/zips/**`, or `dev/workspace/tmp/**` movement. | | ||
| | git diff --check | PASS | No whitespace errors. | | ||
| | npm run validate:canonical-structure | PASS | Blocking violations: 0; approved legacy exceptions: 499. | | ||
| | Runtime/API/UI/database changes | PASS | None. Governance/report-only audit. | |
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The repo instructions for BUILD packaging require the delta ZIP at
<project folder>/tmp/<TASK_NAME>_delta.zip, but this checklist marks the ZIP requirement as passing while documentingdev/workspace/zips/instead. Consumers and validators that look in the mandatedtmp/location will not find the required handoff artifact, so this should be regenerated/reported at the required path.Useful? React with 👍 / 👎.