-
Notifications
You must be signed in to change notification settings - Fork 0
PR_26180_OWNER_019b-move-browser-shared-schemas-to-www #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ToolboxAid
wants to merge
1
commit into
PR_26180_OWNER_019a-contracts-schemas-obsolescence-audit
Choose a base branch
from
PR_26180_OWNER_019b-move-browser-shared-schemas-to-www
base: PR_26180_OWNER_019a-contracts-schemas-obsolescence-audit
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
...rts/PR_26180_OWNER_019b-move-browser-shared-schemas-to-www_branch-validation.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| # PR_26180_OWNER_019b-move-browser-shared-schemas-to-www Branch Validation | ||
|
|
||
| | Check | Status | Evidence | | ||
| | --- | --- | --- | | ||
| | Current branch | PASS | `PR_26180_OWNER_019b-move-browser-shared-schemas-to-www` | | ||
| | Expected stacked base | PASS | Branch created from `PR_26180_OWNER_019a-contracts-schemas-obsolescence-audit`. | | ||
| | Worktree at start | PASS | Clean before branch creation. | | ||
| | Worktree after implementation | PASS | Contains only scoped PR changes and generated reports. | | ||
| | Branch model | PASS | Owner stacked PR based on prior direct dependency. | | ||
| | Protected developer workspace | PASS | No protected dev workspace paths moved. | | ||
|
|
||
| ## Current Status Snapshot | ||
|
|
||
| ```text | ||
| M dev/build/ProjectInstructions/PROJECT_INSTRUCTIONS.md | ||
| M dev/build/ProjectInstructions/PROJECT_INSTRUCTIONS_VERSION.md | ||
| M dev/build/ProjectInstructions/PROJECT_STATE.md | ||
| M dev/build/ProjectInstructions/backlog/BACKLOG_MASTER.md | ||
| M dev/build/ProjectInstructions/repository/canonical_repository_structure.md | ||
| M dev/reports/codex_changed_files.txt | ||
| M dev/reports/codex_review.diff | ||
| M dev/scripts/validate-json-contracts.mjs | ||
| M dev/tests/tools/ObjectVectorStudioV2DeleteCleanup.test.mjs | ||
| M dev/tests/tools/ToolManifestBoundary.test.mjs | ||
| R src/shared/contracts/replayContracts.js -> www/src/shared/contracts/replayContracts.js | ||
| R src/shared/schemas/tools/3d-asset-viewer.schema.json -> www/src/shared/schemas/tools/3d-asset-viewer.schema.json | ||
| R src/shared/schemas/tools/3d-camera-path-editor.schema.json -> www/src/shared/schemas/tools/3d-camera-path-editor.schema.json | ||
| R src/shared/schemas/tools/3d-json-payload.schema.json -> www/src/shared/schemas/tools/3d-json-payload.schema.json | ||
| R src/shared/schemas/tools/asset-manager-v2.schema.json -> www/src/shared/schemas/tools/asset-manager-v2.schema.json | ||
| R src/shared/schemas/tools/asset-pipeline.schema.json -> www/src/shared/schemas/tools/asset-pipeline.schema.json | ||
| R src/shared/schemas/tools/audio-sfx-playground-v2.schema.json -> www/src/shared/schemas/tools/audio-sfx-playground-v2.schema.json | ||
| R src/shared/schemas/tools/collision-inspector-v2.schema.json -> www/src/shared/schemas/tools/collision-inspector-v2.schema.json | ||
| R src/shared/schemas/tools/input-mapping-v2.schema.json -> www/src/shared/schemas/tools/input-mapping-v2.schema.json | ||
| R src/shared/schemas/tools/midi-studio-v2.schema.json -> www/src/shared/schemas/tools/midi-studio-v2.schema.json | ||
| R src/shared/schemas/tools/object-vector-studio-v2.schema.json -> www/src/shared/schemas/tools/object-vector-studio-v2.schema.json | ||
| R src/shared/schemas/tools/palette-browser.schema.json -> www/src/shared/schemas/tools/palette-browser.schema.json | ||
| R src/shared/schemas/tools/palette-manager-v2.schema.json -> www/src/shared/schemas/tools/palette-manager-v2.schema.json | ||
| R src/shared/schemas/tools/parallax-editor.schema.json -> www/src/shared/schemas/tools/parallax-editor.schema.json | ||
| R src/shared/schemas/tools/performance-profiler.schema.json -> www/src/shared/schemas/tools/performance-profiler.schema.json | ||
| R src/shared/schemas/tools/physics-sandbox.schema.json -> www/src/shared/schemas/tools/physics-sandbox.schema.json | ||
| R src/shared/schemas/tools/replay-visualizer.schema.json -> www/src/shared/schemas/tools/replay-visualizer.schema.json | ||
| R src/shared/schemas/tools/sprite-editor.schema.json -> www/src/shared/schemas/tools/sprite-editor.schema.json | ||
| R src/shared/schemas/tools/state-inspector.schema.json -> www/src/shared/schemas/tools/state-inspector.schema.json | ||
| R src/shared/schemas/tools/svg-asset-studio.schema.json -> www/src/shared/schemas/tools/svg-asset-studio.schema.json | ||
| R src/shared/schemas/tools/text2speech-V2.schema.json -> www/src/shared/schemas/tools/text2speech-V2.schema.json | ||
| R src/shared/schemas/tools/tile-map-editor.schema.json -> www/src/shared/schemas/tools/tile-map-editor.schema.json | ||
| R src/shared/schemas/tools/vector-map-editor.schema.json -> www/src/shared/schemas/tools/vector-map-editor.schema.json | ||
| ``` |
11 changes: 11 additions & 0 deletions
11
..._26180_OWNER_019b-move-browser-shared-schemas-to-www_manual-validation-notes.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # PR_26180_OWNER_019b-move-browser-shared-schemas-to-www Manual Validation Notes | ||
|
|
||
| - Confirmed moved files match PR019a audit `Active browser/runtime dependency` rows. | ||
| - Confirmed representative public schema URLs still resolve through the `www` web root: | ||
| - `/src/shared/schemas/tools/object-vector-studio-v2.schema.json` | ||
| - `/src/shared/schemas/tools/text2speech-V2.schema.json` | ||
| - `/src/shared/schemas/tools/palette-browser.schema.json` | ||
| - `/src/shared/contracts/replayContracts.js` | ||
| - Confirmed no API/server files were moved. | ||
| - Confirmed no protected developer workspace files were moved. | ||
| - Confirmed no product/UI/database implementation files changed. |
67 changes: 67 additions & 0 deletions
67
dev/reports/PR_26180_OWNER_019b-move-browser-shared-schemas-to-www_report.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| # PR_26180_OWNER_019b-move-browser-shared-schemas-to-www Report | ||
|
|
||
| ## Executive Summary | ||
|
|
||
| Moved the PR019a-audited active browser/runtime shared contract and tool schema files from root `src/shared/` into `www/src/shared/`. | ||
|
|
||
| This preserves public browser route compatibility because the local/static web root serves `www/`, so URLs such as `/src/shared/schemas/tools/palette-browser.schema.json` still resolve to `www/src/shared/schemas/tools/palette-browser.schema.json`. | ||
|
|
||
| No API/server-owned files, validation-only files, protected developer workspace files, UI pages, database files, or product behavior were moved. | ||
|
|
||
| ## Stack Context | ||
|
|
||
| - Workstream: Repository Architecture Simplification | ||
| - Previous dependency: `PR_26180_OWNER_019a-contracts-schemas-obsolescence-audit` | ||
| - Base branch: `PR_26180_OWNER_019a-contracts-schemas-obsolescence-audit` | ||
| - Source branch: `PR_26180_OWNER_019b-move-browser-shared-schemas-to-www` | ||
| - Intended next dependency: remaining server/API and dev-owned `src/` retirement PRs | ||
|
|
||
| ## Source Of Truth | ||
|
|
||
| Used `dev/reports/PR_26180_OWNER_019a-contracts-schemas-obsolescence-audit_audit.csv`. | ||
|
|
||
| Only rows classified as `Active browser/runtime dependency` with recommendation `move to www/` were moved. | ||
|
|
||
| ## Moved Files | ||
|
|
||
| - src/shared/contracts/replayContracts.js -> www/src/shared/contracts/replayContracts.js | ||
| - src/shared/schemas/tools/3d-asset-viewer.schema.json -> www/src/shared/schemas/tools/3d-asset-viewer.schema.json | ||
| - src/shared/schemas/tools/3d-camera-path-editor.schema.json -> www/src/shared/schemas/tools/3d-camera-path-editor.schema.json | ||
| - src/shared/schemas/tools/3d-json-payload.schema.json -> www/src/shared/schemas/tools/3d-json-payload.schema.json | ||
| - src/shared/schemas/tools/asset-manager-v2.schema.json -> www/src/shared/schemas/tools/asset-manager-v2.schema.json | ||
| - src/shared/schemas/tools/asset-pipeline.schema.json -> www/src/shared/schemas/tools/asset-pipeline.schema.json | ||
| - src/shared/schemas/tools/audio-sfx-playground-v2.schema.json -> www/src/shared/schemas/tools/audio-sfx-playground-v2.schema.json | ||
| - src/shared/schemas/tools/collision-inspector-v2.schema.json -> www/src/shared/schemas/tools/collision-inspector-v2.schema.json | ||
| - src/shared/schemas/tools/input-mapping-v2.schema.json -> www/src/shared/schemas/tools/input-mapping-v2.schema.json | ||
| - src/shared/schemas/tools/midi-studio-v2.schema.json -> www/src/shared/schemas/tools/midi-studio-v2.schema.json | ||
| - src/shared/schemas/tools/object-vector-studio-v2.schema.json -> www/src/shared/schemas/tools/object-vector-studio-v2.schema.json | ||
| - src/shared/schemas/tools/palette-browser.schema.json -> www/src/shared/schemas/tools/palette-browser.schema.json | ||
| - src/shared/schemas/tools/palette-manager-v2.schema.json -> www/src/shared/schemas/tools/palette-manager-v2.schema.json | ||
| - src/shared/schemas/tools/parallax-editor.schema.json -> www/src/shared/schemas/tools/parallax-editor.schema.json | ||
| - src/shared/schemas/tools/performance-profiler.schema.json -> www/src/shared/schemas/tools/performance-profiler.schema.json | ||
| - src/shared/schemas/tools/physics-sandbox.schema.json -> www/src/shared/schemas/tools/physics-sandbox.schema.json | ||
| - src/shared/schemas/tools/replay-visualizer.schema.json -> www/src/shared/schemas/tools/replay-visualizer.schema.json | ||
| - src/shared/schemas/tools/sprite-editor.schema.json -> www/src/shared/schemas/tools/sprite-editor.schema.json | ||
| - src/shared/schemas/tools/state-inspector.schema.json -> www/src/shared/schemas/tools/state-inspector.schema.json | ||
| - src/shared/schemas/tools/svg-asset-studio.schema.json -> www/src/shared/schemas/tools/svg-asset-studio.schema.json | ||
| - src/shared/schemas/tools/text2speech-V2.schema.json -> www/src/shared/schemas/tools/text2speech-V2.schema.json | ||
| - src/shared/schemas/tools/tile-map-editor.schema.json -> www/src/shared/schemas/tools/tile-map-editor.schema.json | ||
| - src/shared/schemas/tools/vector-map-editor.schema.json -> www/src/shared/schemas/tools/vector-map-editor.schema.json | ||
|
|
||
| ## Path Updates | ||
|
|
||
| - Updated active tool/schema tests to read browser tool schemas from `www/src/shared/schemas/tools/`. | ||
| - Updated `dev/scripts/validate-json-contracts.mjs` so tool schema validation indexes `www/src/shared/schemas/tools/` while still indexing remaining root `src/shared/schemas/` files. | ||
| - Updated Project Instructions version/state/canonical structure/backlog to record the browser schema/contract ownership split. | ||
|
|
||
| ## Compatibility Decision | ||
|
|
||
| Schema `$id` values and browser string identifiers remain in the public `src/shared/schemas/tools/...` form. This is intentional because the public browser URL shape remains `/src/shared/...` under the `www` web root. | ||
|
|
||
| ## Scope Guard | ||
|
|
||
| - Runtime behavior changed: No | ||
| - Product/UI pages changed: No | ||
| - API/server files moved: No | ||
| - Database files changed: No | ||
| - Protected developer workspace moved: No |
16 changes: 16 additions & 0 deletions
16
...PR_26180_OWNER_019b-move-browser-shared-schemas-to-www_requirement-checklist.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # PR_26180_OWNER_019b-move-browser-shared-schemas-to-www Requirement Checklist | ||
|
|
||
| | Requirement | Status | Evidence | | ||
| | --- | --- | --- | | ||
| | Use PR019a audit as source of truth | PASS | Moved only `Active browser/runtime dependency` rows from PR019a audit CSV. | | ||
| | Move active browser/runtime contracts and schemas to `www/src/shared/` | PASS | 23 audited files moved to `www/src/shared/`. | | ||
| | Preserve dynamic browser schema loading | PASS | `/src/shared/schemas/tools/<tool>.schema.json` route shape resolves from `www/src/shared/schemas/tools/`. | | ||
| | Preserve public `/src/shared/...` URLs | PASS | Static route resolver check passed for representative schema and replay contract URLs. | | ||
| | Update browser/runtime imports only where required | PASS | Existing browser relative imports continued to resolve; no browser/API behavior changes required. | | ||
| | Do not move validation-only files | PASS | Remaining root validation-only schemas/contracts were not moved. | | ||
| | Do not move API/server files | PASS | No `api/` files moved. | | ||
| | Do not delete schemas/contracts unless audit proves unused | PASS | No schema/contract deletion performed. | | ||
| | Do not change product behavior | PASS | Route compatibility and focused Playwright route smoke passed. | | ||
| | Do not move protected developer workspace files | PASS | No protected `dev/workspace/generated`, `zips`, or `tmp` files moved. | | ||
| | Required reports under `dev/reports/` | PASS | Reports generated. | | ||
| | Required ZIP under `dev/workspace/zips/` | PASS | ZIP generated separately after report creation. | |
19 changes: 19 additions & 0 deletions
19
...rts/PR_26180_OWNER_019b-move-browser-shared-schemas-to-www_validation-report.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # PR_26180_OWNER_019b-move-browser-shared-schemas-to-www Validation Report | ||
|
|
||
| | Validation | Status | Notes | | ||
| | --- | --- | --- | | ||
| | Startup validation | PASS | Loaded Project Instructions v2026.06.28.018 before work; PR updates version to v2026.06.28.019. | | ||
| | Branch validation | PASS | Started from `PR_26180_OWNER_019a-contracts-schemas-obsolescence-audit`; created stacked branch `PR_26180_OWNER_019b-move-browser-shared-schemas-to-www`. | | ||
| | `node --check dev/scripts/validate-json-contracts.mjs` | PASS | Syntax check passed. | | ||
| | `node --check dev/tests/tools/ToolManifestBoundary.test.mjs` | PASS | Syntax check passed. | | ||
| | `node --check dev/tests/tools/ObjectVectorStudioV2DeleteCleanup.test.mjs` | PASS | Syntax check passed. | | ||
| | Targeted node tests | PASS | `ToolManifestBoundary` and `StaticWebRootCompatibility` passed. | | ||
| | Static schema URL checks | PASS | Representative `/src/shared/schemas/tools/...` and `/src/shared/contracts/replayContracts.js` routes resolve from `www/`. | | ||
| | Browser import/reference scan | PASS | No browser code imports top-level `api/`; stale active root filesystem schema references were updated. Public schema IDs remain intentionally unchanged. | | ||
| | Focused Playwright route smoke | PASS | `dev/tests/playwright/tools/StaticWebRootCompatibility.spec.mjs`: 2/2 passed. | | ||
| | `npm run validate:canonical-structure` | PASS | Canonical repository structure guardrail passed. | | ||
| | `git diff --check` | PASS | Passed; Git reported line-ending normalization warnings only. | | ||
|
|
||
| ## Notes | ||
|
|
||
| `dev/tests/tools/ObjectVectorStudioV2DeleteCleanup.test.mjs` is not part of the active node test runner and still depends on a removed legacy Object Vector tool module path from before this PR. This PR updated only its schema file path for the moved browser schema; it did not expand into legacy test resurrection. |
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When callers use
--ci(for exampledev/scripts/PS/validate-tool-schemas.ps1 -Ci), adding the movedwww/src/shared/schemastree to the schema index makes this script evaluate all 22 payload schemas with the old failure criteria: strictness inventory rows count as CI failures, andvalidateToolSchemasstill requires roottool/versionfields these schemas do not declare.node dev/scripts/validate-json-contracts.mjs --mode tools --cinow reports all 22 tool schemas invalid and exits 1, so the JSON-contract validation path is broken unless the CI criteria are updated for these moved schemas.Useful? React with 👍 / 👎.