PR_26180_OWNER_022-delete-remaining-root-src-files#302
Draft
ToolboxAid wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
HARD STOP. No root
src/files were deleted, archived, or moved.Reason
The required reference audit found active current validation/test/tooling references that still require root
src/sharedfiles. The task explicitly requires a hard stop if runtime, test, package, or CI references still require rootsrc.Evidence
git ls-files -- srcbefore: 65 tracked filesgit ls-files -- srcafter: 65 tracked filessrcscan found active references from dev tests, validation scripts, and toolbox-dev guard baselines.InMemoryProjectDataStore.test.mjs: PASSToolManifestBoundary.test.mjs: PASSContractIndexValidation.test.mjs: FAILS on missing legacysrc/shared/contracts/replayContracts.jsValidation
git diff --check: PASSgit diff --cached --check: PASS before commitnpm run validate:canonical-structure: PASSsrcreference scan: HARD STOP condition confirmedReports and Artifact
dev/reports/PR_26180_OWNER_022-delete-remaining-root-src-files_report.mddev/reports/PR_26180_OWNER_022-delete-remaining-root-src-files_requirement-checklist.mddev/reports/PR_26180_OWNER_022-delete-remaining-root-src-files_validation-report.mddev/workspace/zips/PR_26180_OWNER_022-delete-remaining-root-src-files_HARD_STOP.zipRecommendation
Create a follow-up migration PR to move or retire the active tests/scripts/tooling references away from root
src/shared, then retry deletion only after rootsrchas no active runtime/test/package/CI dependencies.