Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# Branch Validation - PR_26180_OWNER_022-resolve-remaining-src-dependencies

- Current branch: `PR_26180_OWNER_022-resolve-remaining-src-dependencies`
- Current branch is not `main`: PASS
- Base branch used: `PR_26180_OWNER_021-archive-legacy-games-samples-teardown`
- Base commit: `2e38e9e31`
- `www/` exists: PASS
- `api/` exists: PASS
- Root tracked `assets/`: 0 files, PASS
- Root tracked `games/`: 0 files, PASS
- Root tracked `learn/`: 0 files, PASS
- Root tracked `toolbox/`: 0 files, PASS
- Root `src` files before cleanup: 65
- Root `src` files after cleanup: 64

## Result

PASS
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Manual Validation Notes - PR_26180_OWNER_022-resolve-remaining-src-dependencies

- No manual browser route validation was required because public URLs and product behavior were not changed.
- `www/toolbox/toolRegistry.js` import smoke returned 47 tools after the path correction.
- Full `src/` retirement remains out of scope.
- `-v2` contracts and manifest/sample schemas remain root `src` transition files because active validation still references them.
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
# PR_26180_OWNER_022-resolve-remaining-src-dependencies Report

## Executive Summary

Rebuilt PR022 from the migration stack base `PR_26180_OWNER_021-archive-legacy-games-samples-teardown` at `2e38e9e31`, not from `main`.

The rebuilt PR is intentionally narrow:

- Deletes obsolete `src/shared/projectDataStore/inMemoryProjectDataStore.js`.
- Deletes the stale self-test that only validated that obsolete in-memory store.
- Confirms `src/shared/number/numbers.js` is not present on PR021 and the active equivalent remains at `www/src/shared/number/numbers.js`.
- Preserves `-v2` tool contract files because active dev contract tests still import them.
- Preserves manifest-era/sample-era schemas because active validation still references them.
- Updates `www/toolbox/toolRegistry.js` to import the existing `www/src/shared/toolbox/tool-metadata-inventory.js` equivalent rather than traversing to root `src`.

## Branch Model

- Model: Owner stacked PR
- Base branch: `PR_26180_OWNER_021-archive-legacy-games-samples-teardown`
- Base commit: `2e38e9e31`
- Source branch: `PR_26180_OWNER_022-resolve-remaining-src-dependencies`
- Rebuilt from migration stack: YES
- Used `main` as base: NO

## Migration Stack Gates

| Gate | Result |
|---|---:|
| Current branch is not `main` | PASS |
| `www/` exists | PASS |
| `api/` exists | PASS |
| root `assets/` tracked active folder absent | PASS |
| root `games/` tracked active folder absent | PASS |
| root `learn/` tracked active folder absent | PASS |
| root `toolbox/` tracked active folder absent | PASS |

## Root Src Count

- Before: 65 tracked files under `src/`
- After: 64 tracked files under `src/`

## Cleanup Decisions

| Item | Decision | Reason |
|---|---|---|
| `src/shared/projectDataStore/inMemoryProjectDataStore.js` | Deleted | Obsolete in-memory project data store; no active references remain after deleting stale self-test. |
| `dev/tests/shared/InMemoryProjectDataStore.test.mjs` | Deleted | Test only validated the deleted obsolete helper. |
| `src/shared/number/numbers.js` | No action | Root file is absent; active equivalent exists under `www/src/shared/number/numbers.js`. |
| `-v2` tool contract files under `src/shared/contracts/tools/` | Preserved | Active dev contract tests import these modules directly. |
| `src/shared/schemas/game.manifest.schema.json` | Preserved | Active `validate-json-contracts` and fixtures still reference it. |
| `src/shared/schemas/samples/sample.tool-payload.schema.json` | Preserved | Active sample validation reports and `ToolManifestBoundary` still reference it. |
| `www/toolbox/toolRegistry.js` import path | Updated | Existing equivalent is under `www/src/shared/toolbox/`; avoids root `src` traversal. |

## Protected Paths

No files under `dev/workspace/generated/tool-images/**` were touched.

## Validation Summary

- `git diff --check`: PASS
- `npm run validate:canonical-structure`: PASS
- `node --check www/toolbox/toolRegistry.js`: PASS
- Browser registry import smoke: PASS, returned 47 tools
- `node ./dev/tests/shared/ProjectDataStoreContract.test.mjs`: PASS
- `node ./dev/tests/dev-runtime/ArchitectureCleanupApiNavInvitations.test.mjs`: PASS
- `node ./dev/tests/tools/ToolManifestBoundary.test.mjs`: PASS
- Targeted root `src` reference scans: PASS with active references documented and preserved

## Outcome

PR022 has been rebuilt from PR021 and is ready as a narrow migration-stack cleanup branch. It does not attempt broad `src/` retirement.
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Requirement Checklist - PR_26180_OWNER_022-resolve-remaining-src-dependencies

| Requirement | Status | Notes |
|---|---:|---|
| Checkout PR021 base | PASS | Rebuilt from `PR_26180_OWNER_021-archive-legacy-games-samples-teardown`. |
| Hard stop if current branch is main | PASS | Work performed on PR022 branch. |
| Hard stop if `www/` or `api/` missing | PASS | Both present. |
| Hard stop if root tracked `assets/`, `games/`, `learn/`, `toolbox/` exist | PASS | Tracked counts are 0. |
| Confirm remaining root `src` files | PASS | 65 before cleanup. |
| Delete `inMemoryProjectDataStore.js` | PASS | Deleted. |
| Resolve `src/shared/number/numbers.js` | PASS | Root file absent; `www/src/shared/number/numbers.js` exists. |
| Delete/archive obsolete `-v2` toolId files | PASS | None deleted because active tests reference them. |
| Delete/archive manifest/sample files only after scan | PASS | Preserved due active validation references. |
| Do not touch `dev/workspace/generated/tool-images/**` | PASS | Protected path untouched. |
| Preserve runtime behavior | PASS | Only path correction and obsolete validation helper deletion. |
| Run required validation | PASS | See validation report. |
| Produce ZIP under `dev/workspace/zips/` | PASS | `_delta.zip` created. |
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
# Validation Report - PR_26180_OWNER_022-resolve-remaining-src-dependencies

## Commands

```text
git diff --check
npm run validate:canonical-structure
node --check www/toolbox/toolRegistry.js
node --input-type=module -e "const m=await import('./www/toolbox/toolRegistry.js'); console.log(m.getToolRegistrySnapshot().tools.length);"
node ./dev/tests/shared/ProjectDataStoreContract.test.mjs
node ./dev/tests/dev-runtime/ArchitectureCleanupApiNavInvitations.test.mjs
node ./dev/tests/tools/ToolManifestBoundary.test.mjs
```

## Targeted Scans

- `git ls-files -- src` count before/after
- active references to `src/shared/projectDataStore/inMemoryProjectDataStore.js`
- active references to root `src/shared/number/numbers.js`
- `toolId: "*-v2"` files under `src`
- active imports of matching `-v2` contract files
- active references to `game.manifest.schema.json` and `sample.tool-payload.schema.json`

## Results

- `git diff --check`: PASS
- `npm run validate:canonical-structure`: PASS
- `node --check www/toolbox/toolRegistry.js`: PASS
- Browser registry import smoke: PASS, returned 47 tools
- `ProjectDataStoreContract.test.mjs`: PASS
- `ArchitectureCleanupApiNavInvitations.test.mjs`: PASS
- `ToolManifestBoundary.test.mjs`: PASS
- Root `src` count: 65 before, 64 after
- In-memory store scan: PASS, no active references remain
- Root number helper scan: PASS, root file absent; active references use `www/src/shared/number/numbers.js`
- `-v2` contract scan: PASS, active test references documented and preserved
- Manifest/sample schema scan: PASS, active validation references documented and preserved

## Result

PASS
Binary file modified dev/reports/codex_changed_files.txt
Binary file not shown.
Binary file modified dev/reports/codex_review.diff
Binary file not shown.
147 changes: 0 additions & 147 deletions dev/tests/shared/InMemoryProjectDataStore.test.mjs

This file was deleted.

Binary file not shown.
Loading
Loading