Enhancing ActionData by TuThoThai · Pull Request #221 · TransmodelEcosystem/SIRI

TuThoThai · 2026-05-18T17:18:08Z

Change in Prompt to embed MIME content type
Addition of Url with a specific type to embed MIME content type and language
All served with an example

This PR is to be discussed and merged before PR #210 that adds PublishToAudioAction. To include Url in ActionData addresses @skinkie comment

- Change in `Prompt` to embed MIME content type - Addition of `Url` with a specific type to embed MIME content type and language - All served with an example

skinkie · 2026-05-18T18:20:23Z

I would prefer that the Prompt itself is not changed in function. Hence if an organisation wants to do something with predefined markup that is fine, they can use Url text/html or application/xhtml+xml or maybe even something like image/svg+xml but lets keep the sane default just plain text.

TuThoThai · 2026-05-18T18:37:59Z

Since Url points to a different resource, regardeless of its type, I thought it would be nice to allow people to have a bit more choices in the format for text content in Prompt while taking advantage of adding the content-type attribute.

thbar

I did a first round mostly on "details". I will mull over the general design & see if I can comment more on the overall structure (need more time).

thbar · 2026-05-18T21:06:38Z

@@ -1,4 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
+<!-- edited with XMLSpy v2025 (x64) (https://www.altova.com) by Tu-Tho Thai (Private) -->


Suggested change



Presumably we want this removed?

thbar · 2026-05-18T21:07:55Z

@@ -0,0 +1,131 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!-- (C) Copyright 2005-2012 CEN SIRI -->
+<Siri xmlns="http://www.siri.org.uk/siri" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:d2="http://datex2.eu/schema/2_0RC1/2_0" version="2.0" xsi:schemaLocation="http://www.siri.org.uk/siri ../../xsd/siri.xsd">


The example uses things only found in the upcoming v2.3.0, so presumably this should be (?):

Suggested change

<Siri xmlns="http://www.siri.org.uk/siri" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:d2="http://datex2.eu/schema/2_0RC1/2_0" version="2.0" xsi:schemaLocation="http://www.siri.org.uk/siri ../../xsd/siri.xsd">

<Siri xmlns="http://www.siri.org.uk/siri" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:d2="http://datex2.eu/schema/2_0RC1/2_0" version="2.3.0" xsi:schemaLocation="http://www.siri.org.uk/siri ../../xsd/siri.xsd">

thbar · 2026-05-18T21:08:18Z

@@ -0,0 +1,131 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!-- (C) Copyright 2005-2012 CEN SIRI -->


Suggested change

thbar · 2026-05-18T21:12:23Z

+		</xsd:annotation>
+		<xsd:simpleContent>
+			<xsd:extension base="NaturalLanguageStringStructure">	
+				<xsd:attribute name="content-type" type="xsd:string" default="text/plain" use="optional">


I believe having an attribute cased like content-type (instead of camelCase contentType) is not common in this codebase ; also it feels off in XML in general. Although it maps a HTTP header with that exact name, I would probably go camelCase:

Suggested change

<xsd:attribute name="content-type" type="xsd:string" default="text/plain" use="optional">

<xsd:attribute name="type" type="xsd:string" default="text/plain" use="optional">

(and adapt accordingly elsewhere)

TuThoThai · 2026-05-19T13:34:08Z

During the SIRI-SX meeting of 19 may 2026, the assessment was that the PR is not yet ready for review. Discussed changes / paints points are to be addressed.
Moving back this PR to draft to work on it and make it ready for review on 12 June 2026

- Adding the element Url in ActionDataStructure - Adding the attribute contentType for both Prompt and Url elements - Defining the enumeration related to contentType

TuThoThai · 2026-07-15T17:36:45Z

Based on feedback from the meeting of 19 May 2026, I made the following changes in the PR:

keeping the addition of the element Url in ActionDataStructure
adding the attribute contentType in both Prompt and Url
making the attribute contentType into an enumeration with a very limited list of allowed MIME types

…ndurl.xml delete faulty example from previous try

skinkie · 2026-07-16T08:11:06Z

+- Addition of URL in ActionData
+- Change of Prompt to include the type of content being shared directly, using an enumeration to limit of options
+- Addition of annotation to clarify the use
+


Are we really going to write this here?

Indeed, could be removed but we need to discuss what to do with all of the comments on the top of each XSD

TuThoThai

As per discussion with @haeckerbaer, @skinkie and @thbar on 16 July 2026

TuThoThai · 2026-07-16T08:17:38Z

+				</xsd:attribute>
+				<xsd:attribute ref="xml:lang" use="optional">
+					<xsd:annotation>
+						<xsd:documentation>If the content of the resource is in a single language, specifies which one.</xsd:documentation>


We should encore that only one combination of contentType and xml:lang is allowed

Enhancing ActionData

407f5f8

- Change in `Prompt` to embed MIME content type - Addition of `Url` with a specific type to embed MIME content type and language - All served with an example

TuThoThai requested review from haeckerbaer, skinkie and thbar May 18, 2026 17:18

TuThoThai added SX For everything SIRI-SX Needs CEN documentation Update These require CEN documentation update to match XSD & examples labels May 18, 2026

TuThoThai added this to the v2.3 milestone May 18, 2026

TuThoThai mentioned this pull request May 18, 2026

Adding PublishToAudioAction to SIRI-SX #210

Open

TuThoThai mentioned this pull request May 18, 2026

Définir le support (ou non) de format HTML etalab/transport-profil-siri-fr#12

Open

thbar reviewed May 19, 2026

View reviewed changes

TuThoThai marked this pull request as draft May 19, 2026 13:34

TuThoThai and others added 2 commits July 15, 2026 19:34

Re-work extension of ActionData

1eeadf6

- Adding the element Url in ActionDataStructure - Adding the attribute contentType for both Prompt and Url elements - Defining the enumeration related to contentType

Merge branch 'v2.3-wip' into sx_cr_actiondata_enhancement

aeea607

TuThoThai marked this pull request as ready for review July 15, 2026 17:34

Delete examples/siri_exm_SX/exm_situationExchange_responsewithprompta…

3ce1abd

…ndurl.xml delete faulty example from previous try

TuThoThai requested a review from thbar July 16, 2026 06:56

Lint and update documentation tables

c8d9fe6

skinkie reviewed Jul 16, 2026

View reviewed changes

Merge branch 'v2.3-wip' into sx_cr_actiondata_enhancement

3d3d27c

TuThoThai commented Jul 16, 2026

View reviewed changes

		@@ -1,4 +1,5 @@
		<?xml version="1.0" encoding="UTF-8"?>
		<!-- edited with XMLSpy v2025 (x64) (https://www.altova.com) by Tu-Tho Thai (Private) -->

	<Siri xmlns="http://www.siri.org.uk/siri" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:d2="http://datex2.eu/schema/2_0RC1/2_0" version="2.0" xsi:schemaLocation="http://www.siri.org.uk/siri ../../xsd/siri.xsd">
	<Siri xmlns="http://www.siri.org.uk/siri" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:d2="http://datex2.eu/schema/2_0RC1/2_0" version="2.3.0" xsi:schemaLocation="http://www.siri.org.uk/siri ../../xsd/siri.xsd">

		@@ -0,0 +1,131 @@
		<?xml version="1.0" encoding="UTF-8"?>
		<!-- (C) Copyright 2005-2012 CEN SIRI -->

	<!-- (C) Copyright 2005-2012 CEN SIRI -->
	<!-- (C) Copyright 2005-2026 CEN SIRI -->

	<xsd:attribute name="content-type" type="xsd:string" default="text/plain" use="optional">
	<xsd:attribute name="type" type="xsd:string" default="text/plain" use="optional">

Uh oh!

Conversation

TuThoThai commented May 18, 2026

Uh oh!

skinkie commented May 18, 2026

Uh oh!

TuThoThai commented May 18, 2026

Uh oh!

thbar left a comment

Choose a reason for hiding this comment

Uh oh!

thbar May 18, 2026

Choose a reason for hiding this comment

Uh oh!

thbar May 18, 2026

Choose a reason for hiding this comment

Uh oh!

thbar May 18, 2026

Choose a reason for hiding this comment

Uh oh!

thbar May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TuThoThai commented May 19, 2026

Uh oh!

TuThoThai commented Jul 15, 2026

Uh oh!

skinkie Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

TuThoThai Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

TuThoThai left a comment

Choose a reason for hiding this comment

Uh oh!

TuThoThai Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

thbar May 18, 2026 •

edited

Loading