Skip to content

Fix total summary view #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camillobruni merged 1 commit into from
Jul 22, 2026
+3 −2
Merged

Fix total summary view #576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions resources/suite-runner.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@ export class SuiteRunner {
// When the test is fast and the precision is low (for example with Firefox'
// privacy.resistFingerprinting preference), it's possible that the measured
// total duration for an entire is 0.
const { suiteTotal, suitePrepare } = this.#suiteResults.total;
const suiteTotal = this.#suiteResults.total;
const suitePrepare = this.#suiteResults.prepare;
if (suiteTotal === 0)
throw new Error(`Got invalid 0-time total for suite ${this.#suite.name}: ${suiteTotal}`);
if (this.#params.measurePrepare && suitePrepare === 0)
Expand Down Expand Up @@ -134,7 +135,7 @@ export class SuiteRunner {
total: total,
};
this.#suiteResults.prepare = this.#prepareTime;
this.#suiteResults.total = total;
this.#suiteResults.total += total;
}

async _updateClient(suite = this.#suite) {
Expand Down
Loading