POC: pluggable ingress for substrate#393
Conversation
Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io> agentgateway Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io> extproc docs Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io> revised: docs and manifests Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io> revised: docs and manifests Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io> remove default envoy and scripts Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io> cleanup a bit Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io> cleanup old files from main Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io>
| @@ -0,0 +1,84 @@ | |||
| // Copyright 2026 Google LLC | |||
There was a problem hiding this comment.
Is there a reason why some of the files were renamed? I'm not against refactoring, but if you can keep the meaningful changes to a minimal set. If we rename files, ideally you would contain that in its own commit.
There was a problem hiding this comment.
I don't think they were renamed, at least not literally. The motivation here is to move from Envoy specific type (which was in errors.go) to a protocol neutral interface in route.go, route_resolve.go, route_errors.go, and that's why some old files are replaced by new ones. If there's any ways to simplify the refactor that you would suggest I'm glad to do that
There was a problem hiding this comment.
Right, but the bodies of the functions remained almost the same:
Example: the big switch statement. If you keep the same name as the previous file (errors.go), then the diff will be obvious. Otherwise to review, I will have to manually do a diff between files.
If you do this as separate commits, then it will be much clearer what is going on. Makes reviews faster...
github-project-automation
Bot
moved this to Todo
in Substrate Milestones (go/substrate-milestones)
3 participants
POC for #326, based on the design in https://docs.google.com/document/d/1djurA9d7f7UIW2DhSqyX85Ad8JgkpPPyCbpDy7G7HOs/edit?tab=t.r12pfwjkq9tf#heading=h.68j4yb47rvbt
Key Changes
manifests/ate-install/atenet-router.yamlis the single (extproc-only) router manifesthack/install-ate.shdeploys the basic reference Envoy gateway alongside the router by default, tests are updated