Properly close thread pools#6480
Open
DomGarguilo wants to merge 3 commits into
Open
Conversation
DomGarguilo
marked this pull request as ready for review
July 16, 2026 18:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking through the code for thread pools and looking at how the pools are shutdown/not.
A lot of pools were not shut down at all so I addressed those.
Here are some guidelines I had in mind while looking through the code:
I tried to keep the diff relatively small, butt will definitely help to review the diff with whitespace ignored since the added try blocks add indentation
I ran all of the touched test files to make sure they all pass.