ATLAS-5332: Update apache-atlas PyPI client to require Python 3.13+#686
Open
kumaab wants to merge 1 commit into
Open
ATLAS-5332: Update apache-atlas PyPI client to require Python 3.13+#686kumaab wants to merge 1 commit into
kumaab wants to merge 1 commit into
Conversation
| <version>3.1.0</version> | ||
| <executions> | ||
| <execution> | ||
| <id>python-test</id> |
Contributor
There was a problem hiding this comment.
we are introducing python-tests to be run in addition to the java test suites during maven build. This could potentially fail for certain users who don't have python installed or have the right python version that atlas expects.
should we gate this behind a maven profile -Ppython-tests turning it OFF by default and run only for useers who opt to test python test cases.
| <phase>test</phase> | ||
| <configuration> | ||
| <skip>${skipTests}</skip> | ||
| <executable>python3</executable> |
Contributor
There was a problem hiding this comment.
python3 may not work on windows. please review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Require Python 3.13+ for the
apache-atlasPyPI client (v0.0.16). Adds unit tests, CI, and packaging fixes. Library code is already 3.13-compatible.Breaking: Python ≤ 3.12 users must stay on
0.0.15.What changed
python_requires='>=3.13',requests>=2.34.2, SPDX license metadatasetup.pyreads deps fromrequirements.txt; addMANIFEST.infor reliable wheel buildsmvn -pl intg testhook + GitHub Actions workflow (Python 3.13).tox/,.mypy_cache/, etc.How was this patch tested?
tox,make build check